Skip to content

Commit 8d7c0c0

Browse files
hgh1472mp911de
authored andcommitted
Remove unnecessary parameter.
Remove unnecessary boolean nativeQuery from checkHasNamedParameter of StringQueryUnitTests class. Signed-off-by: hgh1472 <[email protected]> Closes #3827 Original pull request: #3828
1 parent 3f0bd62 commit 8d7c0c0

File tree

1 file changed

+28
-27
lines changed

1 file changed

+28
-27
lines changed

Diff for: spring-data-jpa/src/test/java/org/springframework/data/jpa/repository/query/StringQueryUnitTests.java

+28-27
Original file line numberDiff line numberDiff line change
@@ -42,6 +42,7 @@
4242
* @author Diego Krupitza
4343
* @author Mark Paluch
4444
* @author Aleksei Elin
45+
* @author Gunha Hwang
4546
*/
4647
class StringQueryUnitTests {
4748

@@ -691,32 +692,32 @@ private void checkAlias(String query, String expected, String description, boole
691692
@Test // DATAJPA-1200
692693
void testHasNamedParameter() {
693694

694-
checkHasNamedParameter("select something from x where id = :id", true, "named parameter", true);
695-
checkHasNamedParameter("in the :id middle", true, "middle", false);
696-
checkHasNamedParameter(":id start", true, "beginning", false);
697-
checkHasNamedParameter(":id", true, "alone", false);
698-
checkHasNamedParameter("select something from x where id = :id", true, "named parameter", true);
699-
checkHasNamedParameter(":UPPERCASE", true, "uppercase", false);
700-
checkHasNamedParameter(":lowercase", true, "lowercase", false);
701-
checkHasNamedParameter(":2something", true, "beginning digit", false);
702-
checkHasNamedParameter(":2", true, "only digit", false);
703-
checkHasNamedParameter(":.something", true, "dot", false);
704-
checkHasNamedParameter(":_something", true, "underscore", false);
705-
checkHasNamedParameter(":$something", true, "dollar", false);
706-
checkHasNamedParameter(":\uFE0F", true, "non basic latin emoji", false); //
707-
checkHasNamedParameter(":\u4E01", true, "chinese japanese korean", false);
708-
709-
checkHasNamedParameter("no bind variable", false, "no bind variable", false);
710-
checkHasNamedParameter(":\u2004whitespace", false, "non basic latin whitespace", false);
711-
checkHasNamedParameter("select something from x where id = ?1", false, "indexed parameter", true);
712-
checkHasNamedParameter("::", false, "double colon", false);
713-
checkHasNamedParameter(":", false, "end of query", false);
714-
checkHasNamedParameter(":\u0003", false, "non-printable", false);
715-
checkHasNamedParameter(":*", false, "basic latin emoji", false);
716-
checkHasNamedParameter("\\:", false, "escaped colon", false);
717-
checkHasNamedParameter("::id", false, "double colon with identifier", false);
718-
checkHasNamedParameter("\\:id", false, "escaped colon with identifier", false);
719-
checkHasNamedParameter("select something from x where id = #something", false, "hash", true);
695+
checkHasNamedParameter("select something from x where id = :id", true, "named parameter");
696+
checkHasNamedParameter("in the :id middle", true, "middle");
697+
checkHasNamedParameter(":id start", true, "beginning");
698+
checkHasNamedParameter(":id", true, "alone");
699+
checkHasNamedParameter("select something from x where id = :id", true, "named parameter");
700+
checkHasNamedParameter(":UPPERCASE", true, "uppercase");
701+
checkHasNamedParameter(":lowercase", true, "lowercase");
702+
checkHasNamedParameter(":2something", true, "beginning digit");
703+
checkHasNamedParameter(":2", true, "only digit");
704+
checkHasNamedParameter(":.something", true, "dot");
705+
checkHasNamedParameter(":_something", true, "underscore");
706+
checkHasNamedParameter(":$something", true, "dollar");
707+
checkHasNamedParameter(":\uFE0F", true, "non basic latin emoji"); //
708+
checkHasNamedParameter(":\u4E01", true, "chinese japanese korean");
709+
710+
checkHasNamedParameter("no bind variable", false, "no bind variable");
711+
checkHasNamedParameter(":\u2004whitespace", false, "non basic latin whitespace");
712+
checkHasNamedParameter("select something from x where id = ?1", false, "indexed parameter");
713+
checkHasNamedParameter("::", false, "double colon");
714+
checkHasNamedParameter(":", false, "end of query");
715+
checkHasNamedParameter(":\u0003", false, "non-printable");
716+
checkHasNamedParameter(":*", false, "basic latin emoji");
717+
checkHasNamedParameter("\\:", false, "escaped colon");
718+
checkHasNamedParameter("::id", false, "double colon with identifier");
719+
checkHasNamedParameter("\\:id", false, "escaped colon with identifier");
720+
checkHasNamedParameter("select something from x where id = #something", false, "hash");
720721
}
721722

722723
@Test // DATAJPA-1235
@@ -877,7 +878,7 @@ void checkNumberOfNamedParameters(String query, int expectedSize, String label,
877878
.hasSize(expectedSize);
878879
}
879880

880-
private void checkHasNamedParameter(String query, boolean expected, String label, boolean nativeQuery) {
881+
private void checkHasNamedParameter(String query, boolean expected, String label) {
881882

882883
List<ParameterBinding> bindings = new ArrayList<>();
883884
StringQuery.ParameterBindingParser.INSTANCE.parseParameterBindingsOfQueryIntoBindingsAndReturnCleanedQuery(query,

0 commit comments

Comments
 (0)