Skip to content

Commit 0af8d68

Browse files
committed
Polishing.
Reformat code, fix ticket references in tests. See #3820 Original pull request: #3821.
1 parent 9b02897 commit 0af8d68

File tree

3 files changed

+12
-11
lines changed

3 files changed

+12
-11
lines changed

spring-data-mongodb/src/main/java/org/springframework/data/mongodb/core/MongoServerApiFactoryBean.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ public class MongoServerApiFactoryBean implements FactoryBean<ServerApi> {
3535
private @Nullable Boolean deprecationErrors;
3636
private @Nullable Boolean strict;
3737

38-
/**
38+
/**
3939
* @param version the version string either as the enum name or the server version value.
4040
* @see ServerApiVersion
4141
*/

spring-data-mongodb/src/test/java/org/springframework/data/mongodb/config/MongoClientNamespaceTests.java

+3-2
Original file line numberDiff line numberDiff line change
@@ -21,10 +21,10 @@
2121
import java.util.Collections;
2222
import java.util.concurrent.TimeUnit;
2323

24-
import com.mongodb.ServerApiVersion;
2524
import org.bson.UuidRepresentation;
2625
import org.junit.Test;
2726
import org.junit.runner.RunWith;
27+
2828
import org.springframework.beans.factory.annotation.Autowired;
2929
import org.springframework.context.ApplicationContext;
3030
import org.springframework.data.mongodb.core.MongoClientFactoryBean;
@@ -35,6 +35,7 @@
3535
import com.mongodb.MongoClientSettings;
3636
import com.mongodb.MongoCredential;
3737
import com.mongodb.ServerAddress;
38+
import com.mongodb.ServerApiVersion;
3839
import com.mongodb.connection.ClusterType;
3940

4041
/**
@@ -149,7 +150,7 @@ public void clientWithUUidSettings() {
149150
assertThat(settings.getUuidRepresentation()).isEqualTo(UuidRepresentation.STANDARD);
150151
}
151152

152-
@Test // DATAMONGO-2427
153+
@Test // GH-3820
153154
public void clientWithServerVersion() {
154155

155156
assertThat(ctx.containsBean("client-with-server-api-settings")).isTrue();

spring-data-mongodb/src/test/java/org/springframework/data/mongodb/core/MongoServerApiFactoryBeanTests.java

+8-8
Original file line numberDiff line numberDiff line change
@@ -17,24 +17,24 @@
1717

1818
import static org.assertj.core.api.Assertions.*;
1919

20-
import com.mongodb.ServerApi;
21-
import com.mongodb.ServerApiVersion;
2220
import org.junit.jupiter.api.Test;
21+
2322
import org.springframework.beans.factory.support.DefaultListableBeanFactory;
2423
import org.springframework.beans.factory.support.RootBeanDefinition;
2524
import org.springframework.test.util.ReflectionTestUtils;
2625

27-
import com.mongodb.AutoEncryptionSettings;
26+
import com.mongodb.ServerApi;
27+
import com.mongodb.ServerApiVersion;
2828

2929
/**
3030
* Integration tests for {@link MongoServerApiFactoryBean}.
3131
*
3232
* @author Christoph Strobl
3333
*/
34-
public class MongoServerApiFactoryBeanTests {
34+
class MongoServerApiFactoryBeanTests {
3535

36-
@Test // DATAMONGO-2306
37-
public void createsServerApiForVersionString() {
36+
@Test // GH-3820
37+
void createsServerApiForVersionString() {
3838

3939
RootBeanDefinition definition = new RootBeanDefinition(MongoServerApiFactoryBean.class);
4040
definition.getPropertyValues().addPropertyValue("version", "V1");
@@ -52,8 +52,8 @@ public void createsServerApiForVersionString() {
5252
assertThat(target.getStrict()).isNotPresent();
5353
}
5454

55-
@Test // DATAMONGO-2306
56-
public void createsServerApiForVersionNumber() {
55+
@Test // GH-3820
56+
void createsServerApiForVersionNumber() {
5757

5858
RootBeanDefinition definition = new RootBeanDefinition(MongoServerApiFactoryBean.class);
5959
definition.getPropertyValues().addPropertyValue("version", "1");

0 commit comments

Comments
 (0)