Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Register R2dbcConverter bean and deprecate ReactiveDataAccessStrategy #447

Closed
pmaedel opened this issue Sep 7, 2020 · 2 comments
Closed

Register R2dbcConverter bean and deprecate ReactiveDataAccessStrategy #447

pmaedel opened this issue Sep 7, 2020 · 2 comments
Labels
type: task A general task
Milestone
1.2 RC1 (2020.0.0)

Comments

@pmaedel
Copy link

pmaedel commented Sep 7, 2020

The docs state that R2dbcConverter is recommended to do most of the work.

R2dbcConverter however must be obtained via ReactiveDataAccessStrategy.
This is fine, but should be documented, as I did expect R2dbcConverter to be readily available as a Bean when being so heavily advertised.
@pmaedel pmaedel mentioned this issue Sep 7, 2020
Closed
@mp911de
Copy link
Member

mp911de commented Sep 8, 2020

ReactiveDataAccessStrategy originates from having DatabaseClient using a pluggable data access strategy. Now that DatabaseClient went into Spring Framework and we have a proper R2dbcEntityTemplate, we no longer need ReactiveDataAccessStrategy and can move its parts into R2dbcConverter. A good first step would be exposing getConverter() on R2dbcEntityOperations to align with the other Spring Data modules.

@mp911de mp911de added the type: task A general task label Sep 8, 2020
@mp911de mp911de added this to the 1.2 RC1 (2020.0.0) milestone Sep 8, 2020
mp911de added a commit that referenced this issue Sep 8, 2020
@mp911de
#447 - Register MappingR2dbcConverter as bean.
28edf27 
We now register MappingR2dbcConverter as bean r2dbcConverter.
mp911de added a commit that referenced this issue Sep 8, 2020
@mp911de
#447 - Deprecate ReactiveDataAccessStrategy.
a1081bb 
ReactiveDataAccessStrategy is now deprecated in favor of using StatementMapper, UpdateMapper, and R2dbcConverter directly. The access strategy interface was introduced to allow pluggable access strategies in DatabaseClient. With moving DatabaseClient into Spring Framework, this approach is no longer required.
@mp911de mp911de changed the title Document that R2dbcConverter must be obtained through ReactiveDataAccessStrategy Register R2dbcConverter bean and deprecate ReactiveDataAccessStrategy Sep 8, 2020
@mp911de
Copy link
Member

mp911de commented Sep 8, 2020

I repurposed this ticket to align our converter infrastructure with the other Spring Data modules. R2dbcConverter is now registered as bean and ReactiveDataAccessStrategy is deprecated.

@mp911de mp911de closed this as completed Sep 8, 2020
@wilkinsona wilkinsona mentioned this issue Sep 8, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: task A general task
Projects
None yet
Milestone
1.2 RC1 (2020.0.0)
Development

No branches or pull requests
2 participants
@pmaedel @mp911de