Extract start helper in JedisConnectionFactory integration tests#3316
Closed
l2yujw wants to merge 1 commit intospring-projects:mainfrom
Closed
Extract start helper in JedisConnectionFactory integration tests#3316l2yujw wants to merge 1 commit intospring-projects:mainfrom
l2yujw wants to merge 1 commit intospring-projects:mainfrom
Conversation
Signed-off-by: l2yuPa <jeungwon28@gmail.com>
spring-projects-issues
added
the
status: waiting-for-triage
mp911de
added
status: declined
Member
|
The change doesn't fundamentally improve the arrangement, it just polishes up a few cosmetics requiring more effort to merge it than it brings on the benefit side. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
JedisConnectionFactoryIntegrationTestsrepeatsafterPropertiesSet()andstart()across multiple test cases.Extracting this lifecycle setup into a helper reduces duplication and keeps the tests focused on behavior.
Changes
startFactory()helper to centralize factory initializationstartFactory()How to test
./mvnw test./mvnw -Dtest=JedisConnectionFactoryIntegrationTests test