Skip to content

Commit b59dca9

Browse files
committed
Align HttpMessageConverters builder with WebFlux codecs variants
As of #33894, we introduced a new `HttpMessageConverters` API. While this achieved our goal of focusing converters classpath detection in a single place and avoiding waste, a single `HttpMessageConverters` instance for both client and server added more complexity for developers. This commit aligns the API here with the WebFlux `CodecsConfigurer` to opt for a client/server flavor as the first step in the builder. While this make the sharing of converter instances between server and client impossible, this allows for a simpler API and separates concerns. Closes gh-35187
1 parent ddaf13b commit b59dca9

File tree

17 files changed

+343
-516
lines changed

17 files changed

+343
-516
lines changed

framework-docs/src/main/java/org/springframework/docs/web/webmvc/mvcconfig/mvcconfigmessageconverters/WebConfiguration.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@
3434
public class WebConfiguration implements WebMvcConfigurer {
3535

3636
@Override
37-
public void configureMessageConverters(HttpMessageConverters.Builder builder) {
37+
public void configureMessageConverters(HttpMessageConverters.ServerBuilder builder) {
3838
JsonMapper jsonMapper = JsonMapper.builder()
3939
.findAndAddModules()
4040
.enable(SerializationFeature.INDENT_OUTPUT)

framework-docs/src/main/kotlin/org/springframework/docs/web/webmvc/mvcconfig/mvcconfigmessageconverters/WebConfiguration.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ import java.text.SimpleDateFormat
1616
@Configuration
1717
class WebConfiguration : WebMvcConfigurer {
1818

19-
override fun configureMessageConverters(builder: HttpMessageConverters.Builder) {
19+
override fun configureMessageConverters(builder: HttpMessageConverters.ServerBuilder) {
2020
val jsonMapper = JsonMapper.builder()
2121
.findAndAddModules()
2222
.enable(SerializationFeature.INDENT_OUTPUT)

0 commit comments

Comments
 (0)