Skip to content

Commit f96b9bb

Browse files
committed
Work Around UnboundIdContainer Fails with TestContext
See gh-17543
1 parent b8796d8 commit f96b9bb

8 files changed

+24
-0
lines changed

ldap/src/integration-test/java/org/springframework/security/ldap/DefaultSpringSecurityContextSourceTests.java

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,7 @@
2626
import org.springframework.beans.factory.annotation.Autowired;
2727
import org.springframework.ldap.AuthenticationException;
2828
import org.springframework.ldap.core.support.AbstractContextSource;
29+
import org.springframework.test.annotation.DirtiesContext;
2930
import org.springframework.test.context.ContextConfiguration;
3031
import org.springframework.test.context.junit.jupiter.SpringExtension;
3132

@@ -39,6 +40,8 @@
3940
*/
4041
@ExtendWith(SpringExtension.class)
4142
@ContextConfiguration(classes = UnboundIdContainerConfig.class)
43+
// FIXME: See https://github.com/spring-projects/spring-security/issues/17543
44+
@DirtiesContext
4245
public class DefaultSpringSecurityContextSourceTests {
4346

4447
@Autowired

ldap/src/integration-test/java/org/springframework/security/ldap/SpringSecurityLdapTemplateITests.java

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,7 @@
3434
import org.springframework.ldap.UncategorizedLdapException;
3535
import org.springframework.ldap.core.ContextExecutor;
3636
import org.springframework.security.crypto.codec.Utf8;
37+
import org.springframework.test.annotation.DirtiesContext;
3738
import org.springframework.test.context.ContextConfiguration;
3839
import org.springframework.test.context.junit.jupiter.SpringExtension;
3940

@@ -46,6 +47,8 @@
4647
*/
4748
@ExtendWith(SpringExtension.class)
4849
@ContextConfiguration(classes = UnboundIdContainerConfig.class)
50+
// FIXME: See https://github.com/spring-projects/spring-security/issues/17543
51+
@DirtiesContext
4952
public class SpringSecurityLdapTemplateITests {
5053

5154
@Autowired

ldap/src/integration-test/java/org/springframework/security/ldap/authentication/BindAuthenticatorTests.java

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,7 @@
3636
import org.springframework.security.ldap.DefaultSpringSecurityContextSource;
3737
import org.springframework.security.ldap.UnboundIdContainerConfig;
3838
import org.springframework.security.ldap.search.FilterBasedLdapUserSearch;
39+
import org.springframework.test.annotation.DirtiesContext;
3940
import org.springframework.test.context.ContextConfiguration;
4041
import org.springframework.test.context.junit.jupiter.SpringExtension;
4142

@@ -54,6 +55,8 @@
5455
*/
5556
@ExtendWith(SpringExtension.class)
5657
@ContextConfiguration(classes = UnboundIdContainerConfig.class)
58+
// FIXME: See https://github.com/spring-projects/spring-security/issues/17543
59+
@DirtiesContext
5760
public class BindAuthenticatorTests {
5861

5962
@Autowired

ldap/src/integration-test/java/org/springframework/security/ldap/authentication/PasswordComparisonAuthenticatorTests.java

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,7 @@
3232
import org.springframework.security.crypto.password.NoOpPasswordEncoder;
3333
import org.springframework.security.ldap.DefaultSpringSecurityContextSource;
3434
import org.springframework.security.ldap.UnboundIdContainerConfig;
35+
import org.springframework.test.annotation.DirtiesContext;
3536
import org.springframework.test.context.ContextConfiguration;
3637
import org.springframework.test.context.junit.jupiter.SpringExtension;
3738

@@ -47,6 +48,8 @@
4748
*/
4849
@ExtendWith(SpringExtension.class)
4950
@ContextConfiguration(classes = UnboundIdContainerConfig.class)
51+
// FIXME: See https://github.com/spring-projects/spring-security/issues/17543
52+
@DirtiesContext
5053
public class PasswordComparisonAuthenticatorTests {
5154

5255
@Autowired

ldap/src/integration-test/java/org/springframework/security/ldap/search/FilterBasedLdapUserSearchTests.java

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,7 @@
2727
import org.springframework.security.core.userdetails.UsernameNotFoundException;
2828
import org.springframework.security.ldap.DefaultSpringSecurityContextSource;
2929
import org.springframework.security.ldap.UnboundIdContainerConfig;
30+
import org.springframework.test.annotation.DirtiesContext;
3031
import org.springframework.test.context.ContextConfiguration;
3132
import org.springframework.test.context.junit.jupiter.SpringExtension;
3233

@@ -41,6 +42,8 @@
4142
*/
4243
@ExtendWith(SpringExtension.class)
4344
@ContextConfiguration(classes = UnboundIdContainerConfig.class)
45+
// FIXME: See https://github.com/spring-projects/spring-security/issues/17543
46+
@DirtiesContext
4447
public class FilterBasedLdapUserSearchTests {
4548

4649
@Autowired

ldap/src/integration-test/java/org/springframework/security/ldap/userdetails/DefaultLdapAuthoritiesPopulatorTests.java

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,7 @@
3333
import org.springframework.security.core.authority.AuthorityUtils;
3434
import org.springframework.security.ldap.SpringSecurityLdapTemplate;
3535
import org.springframework.security.ldap.UnboundIdContainerConfig;
36+
import org.springframework.test.annotation.DirtiesContext;
3637
import org.springframework.test.context.ContextConfiguration;
3738
import org.springframework.test.context.junit.jupiter.SpringExtension;
3839

@@ -45,6 +46,8 @@
4546
*/
4647
@ExtendWith(SpringExtension.class)
4748
@ContextConfiguration(classes = UnboundIdContainerConfig.class)
49+
// FIXME: See https://github.com/spring-projects/spring-security/issues/17543
50+
@DirtiesContext
4851
@SuppressWarnings({ "deprecation" })
4952
public class DefaultLdapAuthoritiesPopulatorTests {
5053

ldap/src/integration-test/java/org/springframework/security/ldap/userdetails/LdapUserDetailsManagerTests.java

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,7 @@
3737
import org.springframework.security.ldap.DefaultLdapUsernameToDnMapper;
3838
import org.springframework.security.ldap.SpringSecurityLdapTemplate;
3939
import org.springframework.security.ldap.UnboundIdContainerConfig;
40+
import org.springframework.test.annotation.DirtiesContext;
4041
import org.springframework.test.context.ContextConfiguration;
4142
import org.springframework.test.context.junit.jupiter.SpringExtension;
4243

@@ -53,6 +54,8 @@
5354
*/
5455
@ExtendWith(SpringExtension.class)
5556
@ContextConfiguration(classes = UnboundIdContainerConfig.class)
57+
// FIXME: See https://github.com/spring-projects/spring-security/issues/17543
58+
@DirtiesContext
5659
public class LdapUserDetailsManagerTests {
5760

5861
@Autowired

ldap/src/integration-test/java/org/springframework/security/ldap/userdetails/NestedLdapAuthoritiesPopulatorTests.java

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,7 @@
2929
import org.springframework.ldap.core.DirContextAdapter;
3030
import org.springframework.security.core.GrantedAuthority;
3131
import org.springframework.security.ldap.UnboundIdContainerConfig;
32+
import org.springframework.test.annotation.DirtiesContext;
3233
import org.springframework.test.context.ContextConfiguration;
3334
import org.springframework.test.context.junit.jupiter.SpringExtension;
3435

@@ -40,6 +41,8 @@
4041
*/
4142
@ExtendWith(SpringExtension.class)
4243
@ContextConfiguration(classes = UnboundIdContainerConfig.class)
44+
// FIXME: See https://github.com/spring-projects/spring-security/issues/17543
45+
@DirtiesContext
4346
public class NestedLdapAuthoritiesPopulatorTests {
4447

4548
@Autowired

0 commit comments

Comments
 (0)