Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SupplierClientRegistrationRepository for reactive stack #16750

Open
bilak opened this issue Mar 17, 2025 · 3 comments · May be fixed by #16770
Open

SupplierClientRegistrationRepository for reactive stack #16750

bilak opened this issue Mar 17, 2025 · 3 comments · May be fixed by #16770
Labels
in: oauth2 An issue in OAuth2 modules (oauth2-core, oauth2-client, oauth2-resource-server, oauth2-jose) type: enhancement A general enhancement

Comments

@bilak
Copy link

bilak commented Mar 17, 2025 •
edited
Loading

Expected Behavior

When starting spring boot application with reactive stack (e.g. spring cloud gateway), it would be useful to not fail if IdP is not available at the boot time.

Current Behavior

Currently if IdP is not available and we use provider's issuer-uri property, application won't start.

Context

For non reactive stack there's already SupplierClientRegistrationRepository.

related issues
spring-boot
spring-security
@bilak bilak added status: waiting-for-triage An issue we've not yet triaged type: enhancement A general enhancement labels Mar 17, 2025
@jzheaux
Copy link
Contributor

jzheaux commented Mar 18, 2025

Thanks for the suggestion, @bilak. Are you able to submit a PR to add this?

@jzheaux jzheaux added in: oauth2 An issue in OAuth2 modules (oauth2-core, oauth2-client, oauth2-resource-server, oauth2-jose) and removed status: waiting-for-triage An issue we've not yet triaged labels Mar 18, 2025
@bilak
Copy link
Author

bilak commented Mar 18, 2025

@jzheaux not really, I'm not that familiar with reactive stack. If you give me a guidance on that maybe I can create a PR with test.

franticticktick added a commit to franticticktick/spring-security that referenced this issue Mar 19, 2025
@franticticktick
Add Support SupplierReactiveClientRegistrationRepository
3bd0b2a 
Closes spring-projectsgh-16750

Signed-off-by: Max Batischev <[email protected]>
@franticticktick franticticktick linked a pull request Mar 19, 2025 that will close this issue
Open
@franticticktick
Copy link
Contributor

Hi @jzheaux , @bilak . I linked PR to this ticket with the SupplierReactiveClientRegistrationRepository implementation. In fact, it is not much different from SupplierClientRegistrationRepository despite the reactive stack.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
in: oauth2 An issue in OAuth2 modules (oauth2-core, oauth2-client, oauth2-resource-server, oauth2-jose) type: enhancement A general enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add Support SupplierReactiveClientRegistrationRepository franticticktick/spring-security
3 participants
@jzheaux @bilak @franticticktick