Fix EIP-712/Eip712Method2021 #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wyc
approved these changes
Mar 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #101
Note: there is an inconsistency between the EIP-712 specification and its implementation in
eth-sig-util(used from MetaMask when hashing arrays: MetaMask/eth-sig-util#106. Eip712Method2021 currently relies on arrays, and followseth-sig-util'ssignTypedData_v4implementation. If a newer signing method becomes available ineth-sig-utilthat implements EIP-712 more closely, we should probably follow that. In that case we could distinguish the hashing method either by making a new proof type name/URI or using another property on their proof.