FRW-8773 Added PHPUnit 11 support. (#11131)

olhalivitchuk · web-flow · commit bb21c69a4652 · 2024-11-04T16:07:47.000+02:00
FRW-8773 Added PHP Unit 11 support.
diff --git a/src/Spryker/Zed/Development/DevelopmentConfig.php b/src/Spryker/Zed/Development/DevelopmentConfig.php
@@ -428,7 +428,6 @@ public function getExternalToInternalMap()
     {
         return [
             'codeception/codeception' => 'spryker/testify',
-            'dms/phpunit-arraysubset-asserts' => 'spryker/testify',
             'doctrine/inflector' => 'spryker/doctrine-inflector',
             'egulias/email-validator' => 'spryker/egulias',
             'fakerphp/faker' => 'spryker/testify',
diff --git a/tests/SprykerTest/Zed/Development/Business/CodeStyleSniffer/CodeStyleSnifferTest.php b/tests/SprykerTest/Zed/Development/Business/CodeStyleSniffer/CodeStyleSnifferTest.php
@@ -151,7 +151,7 @@ protected function getCodeStyleSnifferMock(string $developmentModulePath, int $l
                 $developmentConfig,
                 $this->tester->createCodeStylePathResolver(),
             ])
-            ->setMethods(['runSnifferCommand'])
+            ->onlyMethods(['runSnifferCommand'])
             ->getMock();
 
         $codeStyleSnifferMock
diff --git a/tests/SprykerTest/Zed/Development/Business/Composer/Updater/AutoloadUpdaterTest.php b/tests/SprykerTest/Zed/Development/Business/Composer/Updater/AutoloadUpdaterTest.php
@@ -199,7 +199,7 @@ public function autoloadKeys(): array
     protected function getAutoloadUpdaterMock(): AutoloadUpdater
     {
         $autoloadUpdaterMock = $this->getMockBuilder(AutoloadUpdater::class)
-            ->setMethods(['pathExists', 'getPath'])
+            ->onlyMethods(['pathExists', 'getPath'])
             ->getMock();
 
         return $autoloadUpdaterMock;
diff --git a/tests/SprykerTest/Zed/Development/Business/IdeAutoCompletion/Bundle/MethodBuilder/ClientMethodBuilderTest.php b/tests/SprykerTest/Zed/Development/Business/IdeAutoCompletion/Bundle/MethodBuilder/ClientMethodBuilderTest.php
@@ -77,7 +77,7 @@ protected function getClientMethodBuilderMock(): ClientMethodBuilder
         $methodBuilderMock = $this
             ->getMockBuilder(ClientMethodBuilder::class)
             ->setConstructorArgs([$this->getNamespaceExtractorMock()])
-            ->setMethods(['findFileByName', 'isSearchDirectoryAccessible'])
+            ->onlyMethods(['findFileByName', 'isSearchDirectoryAccessible'])
             ->getMock();
 
         $methodBuilderMock
diff --git a/tests/SprykerTest/Zed/Development/Business/IdeAutoCompletion/Bundle/MethodBuilder/FacadeMethodBuilderTest.php b/tests/SprykerTest/Zed/Development/Business/IdeAutoCompletion/Bundle/MethodBuilder/FacadeMethodBuilderTest.php
@@ -79,13 +79,10 @@ public function testFileLookupPrefersInterface(): void
         $methodBuilderMock
             ->expects($this->exactly(1))
             ->method('findFileByName')
-            ->withConsecutive(
-                [$this->equalTo('FooBundleFacadeInterface.php'), $this->anything()],
-            )
-            ->will($this->onConsecutiveCalls(
+            ->willReturnOnConsecutiveCalls(
                 new SplFileInfo(static::BUNDLE_DIRECTORY . 'FooBundle/Business/FooBundleFacadeInterface.php', 'foo', 'bar'),
                 new SplFileInfo(static::BUNDLE_DIRECTORY . 'FooBundle/Business/FooBundleFacade.php', 'foo', 'bar'),
-            ));
+            );
 
         $bundleMethodTransfer = $methodBuilderMock->getMethod($this->getBundleTransfer());
 
@@ -101,14 +98,10 @@ public function testFileLookupFallsBackToConcreteClassIfInterfaceIsMissing(): vo
         $methodBuilderMock
             ->expects($this->exactly(2))
             ->method('findFileByName')
-            ->withConsecutive(
-                [$this->equalTo('FooBundleFacadeInterface.php'), $this->anything()],
-                [$this->equalTo('FooBundleFacade.php'), $this->anything()],
-            )
-            ->will($this->onConsecutiveCalls(
-                null,
-                new SplFileInfo(static::BUNDLE_DIRECTORY . 'FooBundle/Business/FooBundleFacade.php', 'foo', 'bar'),
-            ));
+            ->willReturnOnConsecutiveCalls(
+                null, // First call returns null (interface missing)
+                new SplFileInfo(static::BUNDLE_DIRECTORY . 'FooBundle/Business/FooBundleFacade.php', 'foo', 'bar'), // Second call returns concrete class file
+            );
 
         $bundleMethodTransfer = $methodBuilderMock->getMethod($this->getBundleTransfer());
 
@@ -123,7 +116,7 @@ protected function getFacadeMethodBuilderMock(): FacadeMethodBuilder
         $methodBuilderMock = $this
             ->getMockBuilder(FacadeMethodBuilder::class)
             ->setConstructorArgs([$this->getNamespaceExtractorMock()])
-            ->setMethods(['findFileByName', 'isSearchDirectoryAccessible'])
+            ->onlyMethods(['findFileByName', 'isSearchDirectoryAccessible'])
             ->getMock();
 
         $methodBuilderMock
diff --git a/tests/SprykerTest/Zed/Development/Business/IdeAutoCompletion/Bundle/MethodBuilder/QueryContainerMethodBuilderTest.php b/tests/SprykerTest/Zed/Development/Business/IdeAutoCompletion/Bundle/MethodBuilder/QueryContainerMethodBuilderTest.php
@@ -77,7 +77,7 @@ protected function getQueryContainerMethodBuilderMock(): QueryContainerMethodBui
         $methodBuilderMock = $this
             ->getMockBuilder(QueryContainerMethodBuilder::class)
             ->setConstructorArgs([$this->getNamespaceExtractorMock()])
-            ->setMethods(['findFileByName', 'isSearchDirectoryAccessible'])
+            ->onlyMethods(['findFileByName', 'isSearchDirectoryAccessible'])
             ->getMock();
 
         $methodBuilderMock
diff --git a/tests/SprykerTest/Zed/Development/Business/IdeAutoCompletion/Bundle/MethodBuilder/ServiceMethodBuilderTest.php b/tests/SprykerTest/Zed/Development/Business/IdeAutoCompletion/Bundle/MethodBuilder/ServiceMethodBuilderTest.php
@@ -77,7 +77,7 @@ protected function getServiceMethodBuilderMock(): ServiceMethodBuilder
         $methodBuilderMock = $this
             ->getMockBuilder(ServiceMethodBuilder::class)
             ->setConstructorArgs([$this->getNamespaceExtractorMock()])
-            ->setMethods(['findFileByName', 'isSearchDirectoryAccessible'])
+            ->onlyMethods(['findFileByName', 'isSearchDirectoryAccessible'])
             ->getMock();
 
         $methodBuilderMock
diff --git a/tests/SprykerTest/Zed/Development/Business/IdeAutoCompletion/IdeAutoCompletionWriterTest.php b/tests/SprykerTest/Zed/Development/Business/IdeAutoCompletion/IdeAutoCompletionWriterTest.php
@@ -184,7 +184,7 @@ protected function getDevelopmentConfigMock(): DevelopmentConfig
     {
         $configMock = $this
             ->getMockBuilder(DevelopmentConfig::class)
-            ->setMethods(['getDefaultIdeAutoCompletionOptions'])
+            ->onlyMethods(['getDefaultIdeAutoCompletionOptions'])
             ->getMock();
 
         $configMock
diff --git a/tests/SprykerTest/Zed/Development/Business/PhpMd/Rules/Design/CouplingBetweenObjectsTest.php b/tests/SprykerTest/Zed/Development/Business/PhpMd/Rules/Design/CouplingBetweenObjectsTest.php
@@ -86,7 +86,7 @@ public function testApplyAddsViolationWhenClassIsNotIgnorable(): void
     protected function getCouplingBetweenObjectsMock(): CouplingBetweenObjects
     {
         $mockBuilder = $this->getMockBuilder(CouplingBetweenObjects::class);
-        $mockBuilder->setMethods(['addViolation', 'getIntProperty']);
+        $mockBuilder->onlyMethods(['addViolation', 'getIntProperty']);
 
         $couplingBetweenObjectsMock = $mockBuilder->getMock();
         $couplingBetweenObjectsMock->expects($this->once())->method('getIntProperty')->willReturn(static::THRESHOLD);
@@ -103,7 +103,8 @@ protected function getCouplingBetweenObjectsMock(): CouplingBetweenObjects
     protected function getNodeMock(string $fullyQualifiedClassName, string $nodeName): AbstractNode
     {
         $mockBuilder = $this->getMockBuilder(AbstractNode::class);
-        $mockBuilder->setMethods(['getMetric', 'getName', 'getNamespace', 'getNamespaceName', 'hasSuppressWarningsAnnotationFor', 'getFullQualifiedName', 'getParentName'])
+        $mockBuilder->addMethods(['getNamespace'])
+            ->onlyMethods(['getMetric', 'getName', 'getNamespaceName', 'hasSuppressWarningsAnnotationFor', 'getFullQualifiedName', 'getParentName'])
             ->disableOriginalConstructor();
 
         $nodeMock = $mockBuilder->getMock();
diff --git a/tests/SprykerTest/Zed/Development/Business/PhpMd/Rules/Design/NumberOfChildrenTest.php b/tests/SprykerTest/Zed/Development/Business/PhpMd/Rules/Design/NumberOfChildrenTest.php
@@ -81,7 +81,7 @@ public function testApplyAddsViolationWhenClassIsNotIgnorable(): void
     protected function getNumberOfChildrenMock(): NumberOfChildren
     {
         $mockBuilder = $this->getMockBuilder(NumberOfChildren::class);
-        $mockBuilder->setMethods(['addViolation', 'getIntProperty']);
+        $mockBuilder->onlyMethods(['addViolation', 'getIntProperty']);
 
         $numberOfChildrenMock = $mockBuilder->getMock();
         $numberOfChildrenMock->expects($this->once())->method('getIntProperty')->willReturn(static::THRESHOLD);
@@ -97,7 +97,8 @@ protected function getNumberOfChildrenMock(): NumberOfChildren
     protected function getNodeMock(string $fullyQualifiedClassName): AbstractNode
     {
         $mockBuilder = $this->getMockBuilder(AbstractNode::class);
-        $mockBuilder->setMethods(['getMetric', 'getName', 'getNamespace', 'getNamespaceName', 'hasSuppressWarningsAnnotationFor', 'getFullQualifiedName', 'getParentName'])
+        $mockBuilder->addMethods(['getNamespace'])
+            ->onlyMethods(['getMetric', 'getName', 'getNamespaceName', 'hasSuppressWarningsAnnotationFor', 'getFullQualifiedName', 'getParentName'])
             ->disableOriginalConstructor();
 
         $nodeMock = $mockBuilder->getMock();
diff --git a/tests/SprykerTest/Zed/Development/Business/PhpMd/Rules/Design/TooManyMethodsTest.php b/tests/SprykerTest/Zed/Development/Business/PhpMd/Rules/Design/TooManyMethodsTest.php
@@ -107,7 +107,7 @@ public function testApplyDoesNotAddViolationIfNumberOfMethodsLowerThenThreshold(
     protected function getTooManyMethodsMock(): TooManyMethods
     {
         $mockBuilder = $this->getMockBuilder(TooManyMethods::class);
-        $mockBuilder->setMethods(['addViolation', 'getIntProperty', 'getStringProperty']);
+        $mockBuilder->onlyMethods(['addViolation', 'getIntProperty', 'getStringProperty']);
 
         $tooManyMethodsMock = $mockBuilder->getMock();
         $tooManyMethodsMock->expects($this->any())->method('getStringProperty')->willReturn('/ignore regex pattern/');
@@ -124,7 +124,8 @@ protected function getTooManyMethodsMock(): TooManyMethods
     protected function getNodeMock(string $fullyQualifiedClassName, string $nodeName): AbstractNode
     {
         $mockBuilder = $this->getMockBuilder(AbstractTypeNode::class);
-        $mockBuilder->setMethods(['getMetric', 'getName', 'getNamespace', 'getNamespaceName', 'hasSuppressWarningsAnnotationFor', 'getFullQualifiedName', 'getParentName', 'getMethodNames'])
+        $mockBuilder->addMethods(['getNamespace'])
+            ->onlyMethods(['getMetric', 'getName', 'getNamespaceName', 'hasSuppressWarningsAnnotationFor', 'getFullQualifiedName', 'getParentName', 'getMethodNames'])
             ->disableOriginalConstructor();
 
         $nodeMock = $mockBuilder->getMock();
diff --git a/tests/SprykerTest/Zed/Development/Business/PhpMd/Rules/Design/TooManyPublicMethodsTest.php b/tests/SprykerTest/Zed/Development/Business/PhpMd/Rules/Design/TooManyPublicMethodsTest.php
@@ -106,7 +106,7 @@ public function testApplyDoesNotAddViolationIfNumberOfMethodsLowerThenThreshold(
     protected function getTooManyPublicMethodsMock(): TooManyPublicMethods
     {
         $mockBuilder = $this->getMockBuilder(TooManyPublicMethods::class);
-        $mockBuilder->setMethods(['addViolation', 'getIntProperty', 'getStringProperty']);
+        $mockBuilder->onlyMethods(['addViolation', 'getIntProperty', 'getStringProperty']);
 
         $tooManyMethodsMock = $mockBuilder->getMock();
         $tooManyMethodsMock->expects($this->any())->method('getStringProperty')->willReturn('/ignore regex pattern/');
@@ -123,7 +123,8 @@ protected function getTooManyPublicMethodsMock(): TooManyPublicMethods
     protected function getNodeMock(string $fullyQualifiedClassName, string $nodeName): AbstractNode
     {
         $mockBuilder = $this->getMockBuilder(AbstractTypeNode::class);
-        $mockBuilder->setMethods(['getMetric', 'getName', 'getNamespace', 'getNamespaceName', 'hasSuppressWarningsAnnotationFor', 'getFullQualifiedName', 'getParentName', 'getMethods'])
+        $mockBuilder->addMethods(['getNamespace'])
+            ->onlyMethods(['getMetric', 'getName', 'getNamespaceName', 'hasSuppressWarningsAnnotationFor', 'getFullQualifiedName', 'getParentName', 'getMethods'])
             ->disableOriginalConstructor();
 
         $nodeMock = $mockBuilder->getMock();

Original file line number	Diff line number	Diff line change
`@@ -428,7 +428,6 @@ public function getExternalToInternalMap()`
`428`	`428`	`{`
`429`	`429`	`return [`
`430`	`430`	`'codeception/codeception' => 'spryker/testify',`
`431`		`- 'dms/phpunit-arraysubset-asserts' => 'spryker/testify',`
`432`	`431`	`'doctrine/inflector' => 'spryker/doctrine-inflector',`
`433`	`432`	`'egulias/email-validator' => 'spryker/egulias',`
`434`	`433`	`'fakerphp/faker' => 'spryker/testify',`
Original file line number	Diff line number	Diff line change
`@@ -199,7 +199,7 @@ public function autoloadKeys(): array`
`199`	`199`	`protected function getAutoloadUpdaterMock(): AutoloadUpdater`
`200`	`200`	`{`
`201`	`201`	`$autoloadUpdaterMock = $this->getMockBuilder(AutoloadUpdater::class)`
`202`		`- ->setMethods(['pathExists', 'getPath'])`
	`202`	`+ ->onlyMethods(['pathExists', 'getPath'])`
`203`	`203`	`->getMock();`
`204`	`204`
`205`	`205`	`return $autoloadUpdaterMock;`
Original file line number	Diff line number	Diff line change
`@@ -184,7 +184,7 @@ protected function getDevelopmentConfigMock(): DevelopmentConfig`
`184`	`184`	`{`
`185`	`185`	`$configMock = $this`
`186`	`186`	`->getMockBuilder(DevelopmentConfig::class)`
`187`		`- ->setMethods(['getDefaultIdeAutoCompletionOptions'])`
	`187`	`+ ->onlyMethods(['getDefaultIdeAutoCompletionOptions'])`
`188`	`188`	`->getMock();`
`189`	`189`
`190`	`190`	`$configMock`