From b6c683650b4d628408974ad721c110ef867b91fa Mon Sep 17 00:00:00 2001 From: wanglujie Date: Tue, 10 Dec 2019 09:56:36 +0800 Subject: [PATCH 1/3] update unit test command --- doc/build.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/build.md b/doc/build.md index ff7fcc9467..918cd17453 100644 --- a/doc/build.md +++ b/doc/build.md @@ -50,7 +50,7 @@ Then, we can build and run tests. ```bash go generate ./... -SQLFLOW_TEST_DB=mysql go test -v -q 1 ./... +SQLFLOW_TEST_DB=mysql go test -v -p 1 ./... ``` The commandline `go generate` is necessary to call `protoc` for translating gRPC interface and to call `goyacc` for generating the parser. From 9d66a4b0fc451789f1f412cfab0e5fb05bfd480c Mon Sep 17 00:00:00 2001 From: wanglujie Date: Tue, 10 Dec 2019 10:08:59 +0800 Subject: [PATCH 2/3] update unit test command comment --- doc/build.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/doc/build.md b/doc/build.md index 918cd17453..c8b55b1194 100644 --- a/doc/build.md +++ b/doc/build.md @@ -57,6 +57,8 @@ The commandline `go generate` is necessary to call `protoc` for translating gRPC The environment variable `SQLFLOW_TEST_DB=mysql` specify MySQL as the SQL engine during testing. You can also choose `hive` for Apache Hive and `maxcompute` for Alibaba MaxCompute. +The command `go test` with `-q 1` argument is necessary to run all tests, otherwise you will encounter the same problem as this [`issue`](https://github.com/sql-machine-learning/sqlflow/issues/1283). + ## Editing on Host As the above `docker run` command binds the source code directory on the host computer to the container, we can edit the source code on the host using any editor, VS Code, Emacs, etc. From 3b5b9750ce5632209bace1ef83ec783e12ae8b2d Mon Sep 17 00:00:00 2001 From: wanglujie Date: Tue, 10 Dec 2019 10:11:37 +0800 Subject: [PATCH 3/3] update unit test command comment --- doc/build.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/build.md b/doc/build.md index c8b55b1194..19a613e63c 100644 --- a/doc/build.md +++ b/doc/build.md @@ -57,7 +57,7 @@ The commandline `go generate` is necessary to call `protoc` for translating gRPC The environment variable `SQLFLOW_TEST_DB=mysql` specify MySQL as the SQL engine during testing. You can also choose `hive` for Apache Hive and `maxcompute` for Alibaba MaxCompute. -The command `go test` with `-q 1` argument is necessary to run all tests, otherwise you will encounter the same problem as this [`issue`](https://github.com/sql-machine-learning/sqlflow/issues/1283). +The command `go test` with `-p 1` argument is necessary to run all tests, otherwise you will encounter the same problem as this [`issue`](https://github.com/sql-machine-learning/sqlflow/issues/1283). ## Editing on Host