config: change the use_signal_backend config logic to disable_signal_backend

Author: Julio Guerra

internal/agent.go

@@ -343,7 +343,7 @@ func (a *AgentType) Serve() error {
 
 	token := a.config.BackendHTTPAPIToken()
 	appName := a.config.AppName()
-	appLoginRes, err := appLogin(a.ctx, a.logger, a.client, token, appName, a.appInfo, a.config.UseSignalBackend())
+	appLoginRes, err := appLogin(a.ctx, a.logger, a.client, token, appName, a.appInfo, a.config.DisableSignalBackend())
 	if err != nil {
 		if xerrors.Is(err, context.Canceled) {
 			a.logger.Debug(err)

internal/backend/client.go

@@ -115,7 +115,7 @@ func (c *Client) Health() HealthStatus {
 	return health
 }
 
-func (c *Client) AppLogin(req *api.AppLoginRequest, token string, appName string, useSignalBackend bool) (*api.AppLoginResponse, error) {
+func (c *Client) AppLogin(req *api.AppLoginRequest, token string, appName string, disableSignalBackend bool) (*api.AppLoginResponse, error) {
 	httpReq, err := c.newRequest(&config.BackendHTTPAPIEndpoint.AppLogin)
 	if err != nil {
 		return nil, err
@@ -136,7 +136,7 @@ func (c *Client) AppLogin(req *api.AppLoginRequest, token string, appName string
 
 	c.session = res.SessionId
 
-	if useSignalBackend || res.Features.UseSignals {
+	if !disableSignalBackend && res.Features.UseSignals {
 		c.signalClient = client.NewClient(c.client, c.session)
 
 		// If the default signal URL is not healthy, fallback to the general

internal/client.go

@@ -53,7 +53,7 @@ func (e LoginError) Unwrap() error {
 
 // Login to the backend. When the API request fails, retry for ever and after
 // sleeping some time.
-func appLogin(ctx context.Context, logger *plog.Logger, client *backend.Client, token string, appName string, appInfo *app.Info, useSignalBackend bool) (*api.AppLoginResponse, error) {
+func appLogin(ctx context.Context, logger *plog.Logger, client *backend.Client, token string, appName string, appInfo *app.Info, disableSignalBackend bool) (*api.AppLoginResponse, error) {
 	_, bundleSignature, err := appInfo.Dependencies()
 	if err != nil {
 		logger.Error(withNotificationError{sqerrors.Wrap(err, "could not retrieve the program dependencies")})
@@ -83,7 +83,7 @@ func appLogin(ctx context.Context, logger *plog.Logger, client *backend.Client,
 		case <-ctx.Done():
 			return nil, ctx.Err()
 		default:
-			appLoginRes, err = client.AppLogin(&appLoginReq, token, appName, useSignalBackend)
+			appLoginRes, err = client.AppLogin(&appLoginReq, token, appName, disableSignalBackend)
 			if err == nil && appLoginRes.Status {
 				return appLoginRes, nil
 			}

internal/config/config.go

@@ -222,7 +222,7 @@ const (
 	configKeyRules                     = `rules`
 	configKeySDKMetricsPeriod          = `sdk_metrics_period`
 	configKeyMaxMetricsStoreLength     = `max_metrics_store_length`
-	configKeyUseSignalBackend          = `use_signal_backend`
+	configKeyDisableSignalBackend      = `disable_signal_backend`
 	configKeyStripSensitiveKeyRegexp   = `strip_sensitive_key_regexp`
 	configKeyStripSensitiveValueRegexp = `strip_sensitive_value_regexp`
 )
@@ -271,7 +271,7 @@ func New(logger *plog.Logger) (*Config, error) {
 		{key: configKeyRules, defaultValue: "", hidden: true},
 		{key: configKeySDKMetricsPeriod, defaultValue: configDefaultSDKMetricsPeriod, hidden: true},
 		{key: configKeyMaxMetricsStoreLength, defaultValue: configDefaultMaxMetricsStoreLength, hidden: true},
-		{key: configKeyUseSignalBackend, defaultValue: "", hidden: true},
+		{key: configKeyDisableSignalBackend, defaultValue: "", hidden: true},
 		{key: configKeyStripSensitiveKeyRegexp, defaultValue: configDefaultStripSensitiveKeyRegexp},
 		{key: configKeyStripSensitiveValueRegexp, defaultValue: configDefaultStripSensitiveValueRegexp},
 	}
@@ -413,8 +413,8 @@ func (c *Config) MaxMetricsStoreLength() uint {
 // UseSignalBackend returns true to force the agent to use the signal backend
 // no matter the feature flag. When false, the app-login feature flag tells
 // whether or not to use the signal backend.
-func (c *Config) UseSignalBackend() bool {
-	strip := sanitizeString(c.GetString(configKeyUseSignalBackend))
+func (c *Config) DisableSignalBackend() bool {
+	strip := sanitizeString(c.GetString(configKeyDisableSignalBackend))
 	return strip != ""
 }