Adds TryInto<Transaction> docs with disclaimer

sr-gi · sr-gi · commit f8a01a06a74b · 2021-09-06T12:42:11.000+02:00
See lightningdevkit#1061 (comment)
diff --git a/lightning-block-sync/src/convert.rs b/lightning-block-sync/src/convert.rs
@@ -156,6 +156,7 @@ impl TryInto<(BlockHash, Option<u32>)> for JsonResponse {
 	}
 }
 
+
 impl TryInto<Txid> for JsonResponse {
 	type Error = std::io::Error;
 	fn try_into(self) -> std::io::Result<Txid> {
@@ -181,6 +182,8 @@ impl TryInto<Txid> for JsonResponse {
 	}
 }
 
+/// Converts a JSON value into a transaction. WATCH OUT! this cannot be used form zero-input transactions
+/// (e.g. createrawtransaction). See https://github.com/rust-bitcoin/rust-bitcoincore-rpc/issues/197
 impl TryInto<Transaction> for JsonResponse {
 	type Error = std::io::Error;
 	fn try_into(self) -> std::io::Result<Transaction> {

Original file line number	Diff line number	Diff line change
`@@ -156,6 +156,7 @@ impl TryInto<(BlockHash, Option<u32>)> for JsonResponse {`
`156`	`156`	`}`
`157`	`157`	`}`
`158`	`158`
	`159`	`+`
`159`	`160`	`impl TryInto<Txid> for JsonResponse {`
`160`	`161`	`type Error = std::io::Error;`
`161`	`162`	`fn try_into(self) -> std::io::Result<Txid> {`
`@@ -181,6 +182,8 @@ impl TryInto<Txid> for JsonResponse {`
`181`	`182`	`}`
`182`	`183`	`}`
`183`	`184`
	`185`	`+/// Converts a JSON value into a transaction. WATCH OUT! this cannot be used form zero-input transactions`
	`186`	`+/// (e.g. createrawtransaction). See https://github.com/rust-bitcoin/rust-bitcoincore-rpc/issues/197`
`184`	`187`	`impl TryInto<Transaction> for JsonResponse {`
`185`	`188`	`type Error = std::io::Error;`
`186`	`189`	`fn try_into(self) -> std::io::Result<Transaction> {`