Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve failed upload error message #21

Open
GwydionJon opened this issue Apr 11, 2022 · 2 comments
Open

improve failed upload error message #21

GwydionJon opened this issue Apr 11, 2022 · 2 comments

Comments

@GwydionJon
Copy link
Collaborator

Currently upload_file only reports the filename and id if the upload fails.
From status.get it might be possible to acquire additional information that can be helpful for troubleshooting.
@GwydionJon
Copy link
Collaborator Author

The test_upload_file_invalid_id test does not test for failed upload, but only for a HTTPError.
not sure how to make it fail an upload.

@lkeegan
Copy link
Member

lkeegan commented Apr 12, 2022

Maybe try to upload a file using a token with read-only permissions?
There's already a read-only token stored in the repo secrets as ELABFTW_READ_TOKEN , you can add it as an environment variable to the ci jobs like is already done for the write token: https://github.com/ssciwr/mease-elabftw/blob/main/.github/workflows/test.yml#L23

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lkeegan @GwydionJon