Fix SocketAsyncEventArgsAwaitable calling continuation multiple times (#918)

IgorMilavec · Rob-Hague · web-flow · commit 59840ecdbaad · 2024-04-27T22:43:42.000+02:00
* Fix SocketAsyncEventArgsAwaitable calling continuation multiple times

* Use Interlocked.Exchange

---------

Co-authored-by: Rob Hague &lt;rob.hague00@gmail.com&gt;
diff --git a/src/Renci.SshNet/Abstractions/SocketExtensions.cs b/src/Renci.SshNet/Abstractions/SocketExtensions.cs
@@ -33,11 +33,10 @@ public AwaitableSocketAsyncEventArgs ExecuteAsync(Func<SocketAsyncEventArgs, boo
                 return this;
             }
 
-            public void SetCompleted()
+            private void SetCompleted()
             {
                 IsCompleted = true;
-
-                var continuation = _continuationAction ?? Interlocked.CompareExchange(ref _continuationAction, SENTINEL, comparand: null);
+                var continuation = Interlocked.Exchange(ref _continuationAction, SENTINEL);
                 if (continuation is not null)
                 {
                     continuation();

Original file line number	Diff line number	Diff line change
`@@ -33,11 +33,10 @@ public AwaitableSocketAsyncEventArgs ExecuteAsync(Func<SocketAsyncEventArgs, boo`
`33`	`33`	`return this;`
`34`	`34`	`}`
`35`	`35`
`36`		`- public void SetCompleted()`
	`36`	`+ private void SetCompleted()`
`37`	`37`	`{`
`38`	`38`	`IsCompleted = true;`
`39`		`-`
`40`		`- var continuation = _continuationAction ?? Interlocked.CompareExchange(ref _continuationAction, SENTINEL, comparand: null);`
	`39`	`+ var continuation = Interlocked.Exchange(ref _continuationAction, SENTINEL);`
`41`	`40`	`if (continuation is not null)`
`42`	`41`	`{`
`43`	`42`	`continuation();`