Skip to content

Commit 68dcd0f

Browse files
committed
Remove the testing
1 parent 10101ad commit 68dcd0f

File tree

2 files changed

+3
-42
lines changed

2 files changed

+3
-42
lines changed

.github/workflows/build.yml

Lines changed: 2 additions & 30 deletions
Original file line numberDiff line numberDiff line change
@@ -35,44 +35,16 @@ jobs:
3535
-p:CoverletOutput=../../coverlet/linux_unit_test_net_10_coverage.xml \
3636
test/Renci.SshNet.Tests/
3737
38-
- name: Run Integration Tests .NET 1
38+
- name: Run Integration Tests .NET
3939
run: |
40-
openssl version
4140
dotnet test \
4241
-f net10.0 \
4342
--no-build \
4443
--logger "console;verbosity=normal" \
4544
--logger GitHubActions \
4645
-p:CollectCoverage=true \
4746
-p:CoverletOutputFormat=cobertura \
48-
-p:CoverletOutput=../../coverlet/linux_integration_test_net_10_coverage_1.xml \
49-
test/Renci.SshNet.IntegrationTests/
50-
51-
- name: Run Integration Tests .NET 2
52-
run: |
53-
# ml-kem requires openssl 3.5.0+ https://learn.microsoft.com/en-us/dotnet/standard/security/cross-platform-cryptography#ml-kem
54-
sudo apt remove openssl -y
55-
wget https://github.com/openssl/openssl/releases/download/openssl-3.5.4/openssl-3.5.4.tar.gz
56-
tar -xzvf openssl-3.5.4.tar.gz
57-
cd openssl-3.5.4
58-
./Configure --prefix=/usr/local/ssl --openssldir=/usr/local/ssl shared zlib
59-
make
60-
sudo make install
61-
export LD_LIBRARY_PATH=$LD_LIBRARY_PATH:/usr/local/ssl
62-
export PATH=/usr/local/ssl/bin:$PATH
63-
sudo ldconfig
64-
openssl version
65-
sudo systemctl restart ssh
66-
cd ..
67-
dotnet test \
68-
-f net10.0 \
69-
--logger "console;verbosity=normal" \
70-
--logger GitHubActions \
71-
--filter "Name=MLKem768X25519Sha256" \
72-
-p:DefineConstants="Test_BCL_MLKem" \
73-
-p:CollectCoverage=true \
74-
-p:CoverletOutputFormat=cobertura \
75-
-p:CoverletOutput=../../coverlet/linux_integration_test_net_10_coverage_2.xml \
47+
-p:CoverletOutput=../../coverlet/linux_integration_test_net_10_coverage.xml \
7648
test/Renci.SshNet.IntegrationTests/
7749
7850
- name: Archive Coverlet Results

src/Renci.SshNet/Security/KeyExchangeMLKem768X25519Sha256.cs

Lines changed: 1 addition & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -11,13 +11,7 @@ namespace Renci.SshNet.Security
1111
{
1212
internal sealed partial class KeyExchangeMLKem768X25519Sha256 : KeyExchangeECCurve25519
1313
{
14-
#if Test_BCL_MLKem
15-
private MLKemBclImpl _mlkemImpl;
16-
#elif Test_BouncyCastle_MLKem
17-
private MLKemBouncyCastleImpl _mlkemImpl;
18-
#else
1914
private Impl _mlkemImpl;
20-
#endif
2115

2216
/// <summary>
2317
/// Gets algorithm name.
@@ -45,11 +39,6 @@ protected override void StartImpl()
4539

4640
Session.KeyExchangeHybridReplyMessageReceived += Session_KeyExchangeHybridReplyMessageReceived;
4741

48-
#if Test_BCL_MLKem
49-
_mlkemImpl = new MLKemBclImpl();
50-
#elif Test_BouncyCastle_MLKem
51-
_mlkemImpl = new MLKemBouncyCastleImpl();
52-
#else
5342
if (MLKem.IsSupported)
5443
{
5544
_mlkemImpl = new MLKemBclImpl();
@@ -58,7 +47,7 @@ protected override void StartImpl()
5847
{
5948
_mlkemImpl = new MLKemBouncyCastleImpl();
6049
}
61-
#endif
50+
6251
var mlkem768PublicKey = _mlkemImpl.GenerateClientPublicKey();
6352

6453
var x25519PublicKey = _impl.GenerateClientPublicKey();

0 commit comments

Comments
 (0)