rust: Remove zcash-inspect binary

This has been moved into the `zcash/librustzcash` repository as a
devtool.

Author: str4d

.github/workflows/ci.yml

@@ -277,7 +277,6 @@ jobs:
               ${{ format('./src/zcashd{0}', matrix.file_ext) }}
               ${{ format('./src/zcash-cli{0}', matrix.file_ext) }}
               ${{ format('./src/zcashd-wallet-tool{0}', matrix.file_ext) }}
-              ${{ format('./src/zcash-inspect{0}', matrix.file_ext) }}
               ${{ format('./src/zcash-tx{0}', matrix.file_ext) }}
               ${{ format('./src/test/test_bitcoin{0}', matrix.file_ext) }}
               ${{ format('./src/zcash-gtest{0}', matrix.file_ext) }}

Cargo.lock

@@ -29,10 +29,6 @@ name = "rustzcash"
 path = "src/rust/src/lib.rs"
 crate-type = ["staticlib"]
 
-[[bin]]
-name = "zcash-inspect"
-path = "src/rust/bin/inspect/main.rs"
-
 [[bin]]
 name = "zcashd-wallet-tool"
 path = "src/rust/bin/wallet_tool.rs"
@@ -47,6 +43,7 @@ byteorder = "1"
 crossbeam-channel = "0.5"
 getrandom = "0.2"
 group = "0.13"
+hex = "0.4"
 incrementalmerkletree = "0.5"
 libc = "0.2"
 jubjub = "0.10"
@@ -89,16 +86,6 @@ tokio = { version = "1", features = ["rt", "net", "time"] }
 # General tool dependencies
 gumdrop = "0.8"
 
-# zcash-inspect tool
-bech32 = "0.9"
-equihash = "0.2"
-hex = "0.4"
-lazy_static = "1.4"
-serde = "1.0"
-serde_json = "1.0"
-sha2 = "0.10"
-uint = "0.9"
-
 # Wallet tool
 # (also depends on tracing, and tracing-subscriber with "env-filter" and "fmt" features)
 anyhow = "1.0"

Cargo.toml

@@ -10,3 +10,10 @@ Platform Support
 - Debian 10 (Buster) has been removed from the list of supported platforms.
   It reached EoL on June 30th 2024, and does not satisfy our Tier 2 policy
   requirements.
+
+Other
+-----
+
+- The `zcash-inspect` tool (which was never distributed, and was present in this
+  repository for debugging purposes) has been moved to the `devtools` subfolder
+  of the https://github.com/zcash/librustzcash repository.

doc/release-notes.md

@@ -490,10 +490,6 @@ criteria = "safe-to-deploy"
 version = "0.3.0"
 criteria = "safe-to-deploy"
 
-[[exemptions.ryu]]
-version = "1.0.11"
-criteria = "safe-to-deploy"
-
 [[exemptions.secp256k1]]
 version = "0.26.0"
 criteria = "safe-to-deploy"
@@ -506,10 +502,6 @@ criteria = "safe-to-deploy"
 version = "0.8.0"
 criteria = "safe-to-deploy"
 
-[[exemptions.serde_json]]
-version = "1.0.81"
-criteria = "safe-to-deploy"
-
 [[exemptions.sha2]]
 version = "0.10.8"
 criteria = "safe-to-deploy"

qa/supply-chain/config.toml

@@ -1105,16 +1105,6 @@ who = "Ameer Ghani <[email protected]>"
 criteria = "safe-to-deploy"
 version = "1.12.1"
 
-[[audits.isrg.audits.serde_json]]
-who = "Brandon Pitman <[email protected]>"
-criteria = "safe-to-deploy"
-delta = "1.0.93 -> 1.0.94"
-
-[[audits.isrg.audits.serde_json]]
-who = "Brandon Pitman <[email protected]>"
-criteria = "safe-to-deploy"
-delta = "1.0.94 -> 1.0.95"
-
 [[audits.isrg.audits.thiserror]]
 who = "Brandon Pitman <[email protected]>"
 criteria = "safe-to-deploy"
@@ -1410,36 +1400,6 @@ criteria = "safe-to-deploy"
 delta = "0.6.27 -> 0.6.28"
 aggregated-from = "https://hg.mozilla.org/mozilla-central/raw-file/tip/supply-chain/audits.toml"
 
-[[audits.mozilla.audits.ryu]]
-who = "Mike Hommey <[email protected]>"
-criteria = "safe-to-deploy"
-delta = "1.0.11 -> 1.0.12"
-aggregated-from = "https://hg.mozilla.org/mozilla-central/raw-file/tip/supply-chain/audits.toml"
-
-[[audits.mozilla.audits.serde_json]]
-who = "Mike Hommey <[email protected]>"
-criteria = "safe-to-deploy"
-delta = "1.0.81 -> 1.0.83"
-aggregated-from = "https://hg.mozilla.org/mozilla-central/raw-file/tip/supply-chain/audits.toml"
-
-[[audits.mozilla.audits.serde_json]]
-who = "Mike Hommey <[email protected]>"
-criteria = "safe-to-deploy"
-delta = "1.0.83 -> 1.0.85"
-aggregated-from = "https://hg.mozilla.org/mozilla-central/raw-file/tip/supply-chain/audits.toml"
-
-[[audits.mozilla.audits.serde_json]]
-who = "Mike Hommey <[email protected]>"
-criteria = "safe-to-deploy"
-delta = "1.0.85 -> 1.0.91"
-aggregated-from = "https://hg.mozilla.org/mozilla-central/raw-file/tip/supply-chain/audits.toml"
-
-[[audits.mozilla.audits.serde_json]]
-who = "Mike Hommey <[email protected]>"
-criteria = "safe-to-deploy"
-delta = "1.0.91 -> 1.0.93"
-aggregated-from = "https://hg.mozilla.org/mozilla-central/raw-file/tip/supply-chain/audits.toml"
-
 [[audits.mozilla.audits.socket2]]
 who = "Kershaw Chang <[email protected]>"
 criteria = "safe-to-deploy"
@@ -1530,12 +1490,6 @@ with Rust 1.80 or later.
 """
 aggregated-from = "https://raw.githubusercontent.com/zcash/librustzcash/main/supply-chain/audits.toml"
 
-[[audits.zcash.audits.serde_json]]
-who = "Jack Grigg <[email protected]>"
-criteria = "safe-to-deploy"
-delta = "1.0.117 -> 1.0.120"
-aggregated-from = "https://raw.githubusercontent.com/zcash/librustzcash/main/supply-chain/audits.toml"
-
 [[audits.zcash.audits.thiserror]]
 who = "Daira-Emma Hopwood <[email protected]>"
 criteria = "safe-to-deploy"

qa/supply-chain/imports.lock

@@ -99,7 +99,7 @@ def check_security_hardening():
     else:
         # Equivalent to make check-security (this is just for CI purpose)
         bin_programs = ['src/zcashd', 'src/zcash-cli', 'src/zcash-tx', 'src/bench/bench_bitcoin']  # Replace with actual values
-        bin_scripts = ['src/zcash-inspect', 'src/zcashd-wallet-tool']   # Replace with actual values
+        bin_scripts = ['src/zcashd-wallet-tool']   # Replace with actual values
 
         print(f"Checking binary security of {bin_programs + bin_scripts}...")
 

qa/zcash/full_test_suite.py

@@ -36,9 +36,6 @@ LIBSECP256K1=secp256k1/libsecp256k1.la
 LIBUNIVALUE=univalue/libunivalue.la
 LIBZCASH=libzcash.a
 
-INSPECT_TOOL_BIN=zcash-inspect$(EXEEXT)
-INSPECT_TOOL_BUILD=$(top_builddir)/target/$(RUST_TARGET)/release/zcash-inspect$(EXEEXT)
-
 WALLET_TOOL_BIN=zcashd-wallet-tool$(EXEEXT)
 WALLET_TOOL_BUILD=$(top_builddir)/target/$(RUST_TARGET)/release/zcashd-wallet-tool$(EXEEXT)
 
@@ -158,9 +155,6 @@ cargo-build-lib: cargo-build
 
 cargo-build-bins: cargo-build
 
-$(INSPECT_TOOL_BIN): cargo-build-bins
-	$(AM_V_at)cp $(INSPECT_TOOL_BUILD) $@
-
 $(WALLET_TOOL_BIN): cargo-build-bins
 	$(AM_V_at)cp $(WALLET_TOOL_BUILD) $@
 
@@ -210,7 +204,7 @@ endif
 
 if BUILD_BITCOIN_UTILS
   bin_PROGRAMS += zcash-cli zcash-tx
-  bin_SCRIPTS += $(INSPECT_TOOL_BIN) $(WALLET_TOOL_BIN)
+  bin_SCRIPTS += $(WALLET_TOOL_BIN)
 endif
 
 LIBZCASH_H = \