Tests - Re-add missing tests and fix error code handling (#586)

* reapply test and fix error code handling

* generate files

Author: GalRogozinski

ssv/partial_sig_container.go

@@ -106,7 +106,7 @@ func (ps *PartialSigContainer) ReconstructSignature(root [32]byte, validatorPubK
 	validatorPubKeyCopy := make([]byte, len(validatorPubKey))
 	copy(validatorPubKeyCopy, validatorPubKey)
 
-	if err := types.VerifyReconstructedSignature(signature, validatorPubKeyCopy, root); err != nil {
+	if err = types.VerifyReconstructedSignature(signature, validatorPubKeyCopy, root); err != nil {
 		return nil, errors.Wrap(err, "failed to verify reconstruct signature")
 	}
 	return signature.Serialize(), nil

ssv/spectest/all_tests.go

@@ -183,11 +183,11 @@ var AllTests = []tests.TestF{
 
 	dutyexe.WrongDutyRole,
 	dutyexe.WrongDutyPubKey,
-	// partialsigcontainer.OneSignature,
+	partialsigcontainer.OneSignature,
 	partialsigcontainer.Quorum,
-	// partialsigcontainer.Duplicate,
+	partialsigcontainer.Duplicate,
 	partialsigcontainer.DuplicateQuorum,
-	// partialsigcontainer.Invalid,
+	partialsigcontainer.Invalid,
 
 	runnerconstruction.OneShare,
 	runnerconstruction.NoShares,

ssv/spectest/generate/tests/partialsigcontainer.PartialSigContainerTest_PartialSigContainer_duplicate.json

@@ -20,7 +20,8 @@ func Invalid() tests.SpecTest {
 	msgs := []*types.PartialSignatureMessage{msg1.Messages[0], msg2.Messages[0], msg3.Messages[0]}
 
 	// Verify the reconstructed signature
-	expectedSig, err := types.ReconstructSignatures(map[types.OperatorID][]byte{1: msgs[0].PartialSignature, 2: msgs[1].PartialSignature, 3: msgs[2].PartialSignature})
+	_, err := types.ReconstructSignatures(map[types.OperatorID][]byte{1: msgs[0].PartialSignature,
+		2: msgs[1].PartialSignature, 3: msgs[2].PartialSignature})
 	if err != nil {
 		panic(err.Error())
 	}
@@ -32,7 +33,7 @@ func Invalid() tests.SpecTest {
 		ks.ValidatorPK.Serialize(),
 		msgs,
 		types.ReconstructSignatureErrorCode,
-		expectedSig.Serialize(),
+		nil,
 		true,
 		ks,
 	)

ssv/spectest/generate/tests/partialsigcontainer.PartialSigContainerTest_PartialSigContainer_invalid.json

@@ -18,7 +18,7 @@ func OneSignature() tests.SpecTest {
 	msgs := []*types.PartialSignatureMessage{msg.Messages[0]}
 
 	// Verify the reconstructed signature
-	expectedSig, err := types.ReconstructSignatures(map[types.OperatorID][]byte{1: msgs[0].PartialSignature})
+	_, err := types.ReconstructSignatures(map[types.OperatorID][]byte{1: msgs[0].PartialSignature})
 	if err != nil {
 		panic(err.Error())
 	}
@@ -30,7 +30,7 @@ func OneSignature() tests.SpecTest {
 		ks.ValidatorPK.Serialize(),
 		msgs,
 		types.ReconstructSignatureErrorCode,
-		expectedSig.Serialize(),
+		nil,
 		false,
 		ks,
 	)

ssv/spectest/generate/tests/partialsigcontainer.PartialSigContainerTest_PartialSigContainer_one_signature.json

@@ -48,10 +48,6 @@ func (test *PartialSigContainerTest) Run(t *testing.T) {
 		result, err := ps.ReconstructSignature(root, test.ValidatorPubKey, validatorIndex)
 		// Check the result and error
 		tests.AssertErrorCode(t, test.ExpectedErrorCode, err)
-		if err != nil {
-			require.Contains(t, err.Error(), test.ExpectedErrorCode)
-			return
-		}
 		require.EqualValues(t, test.ExpectedResult, result)
 	}
 }