Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DomainType fits better in config than in committeeMember ( or share for that matter) since its used for everything under the same network and we're not going to have different domainTypes for different shares/members ever unless its a bug. #439

Open
GalRogozinski opened this issue Jun 30, 2024 · 1 comment
Open

DomainType fits better in config than in committeeMember ( or share for that matter) since its used for everything under the same network and we're not going to have different domainTypes for different shares/members ever unless its a bug. #439

GalRogozinski opened this issue Jun 30, 2024 · 1 comment

Comments

@GalRogozinski
Copy link
Contributor

DomainType fits better in config than in committeeMember ( or share for that matter) since its used for everything under the same network and we're not going to have different domainTypes for different shares/members ever unless its a bug.

Originally posted by @y0sher in #433 (review)
@GalRogozinski GalRogozinski mentioned this issue Jul 3, 2024
Merged
@GalRogozinski
Copy link
Contributor Author

One solution is to add another config for SSV. And then have duplicates in SSV and QBFT.
That's fine because they are different packages.

@GalRogozinski GalRogozinski mentioned this issue Oct 13, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@GalRogozinski