fix

Author: staabm

phpstan.neon.dist

@@ -36,3 +36,6 @@ parameters:
         -
             message: '#^Instanceof between mysqli_result<array<string, int<-2147483648, 2147483647>\|string\|null>> and mysqli_result will always evaluate to true\.$#'
             path: src/DbSchema/SchemaHasherMysql.php
+        -
+            message: '#^Public property ".*::\$classMethods" is never used$#'
+            path: src/Rules/*

src/Rules/DoctrineKeyValueStyleRule.php

@@ -33,7 +33,7 @@ final class DoctrineKeyValueStyleRule implements Rule
     /**
      * @var array<array{string, string, list<int>}>
      */
-    private array $classMethods;
+    public array $classMethods;
 
     private ReflectionProvider $reflectionProvider;
 

src/Rules/SyntaxErrorInPreparedStatementMethodRule.php

@@ -31,7 +31,7 @@ final class SyntaxErrorInPreparedStatementMethodRule implements Rule
     /**
      * @var list<string>
      */
-    private array $classMethods;
+    public array $classMethods;
 
     private ReflectionProvider $reflectionProvider;
 

src/Rules/SyntaxErrorInQueryMethodRule.php

@@ -24,7 +24,7 @@ final class SyntaxErrorInQueryMethodRule implements Rule
     /**
      * @var list<string>
      */
-    private array $classMethods;
+    public array $classMethods;
 
     private ReflectionProvider $reflectionProvider;
 

tests/rules/DoctrineKeyValueStyleRuleStrictTest.php

@@ -27,7 +27,11 @@ protected function tearDown(): void
 
     protected function getRule(): Rule
     {
-        return self::getContainer()->getByType(DoctrineKeyValueStyleRule::class);
+        $rule = self::getContainer()->getByType(DoctrineKeyValueStyleRule::class);
+        $rule->classMethods[] = ['staabm\PHPStanDba\Tests\Fixture\Connection', 'assembleNoArrays', []];
+        $rule->classMethods[] = ['staabm\PHPStanDba\Tests\Fixture\Connection', 'assembleOneArray', [1]];
+        $rule->classMethods[] = ['staabm\PHPStanDba\Tests\Fixture\Connection', 'assembleTwoArrays', [1,2]];
+        return $rule;
     }
 
     public static function getAdditionalConfigFiles(): array

tests/rules/DoctrineKeyValueStyleRuleTest.php

@@ -15,7 +15,11 @@ class DoctrineKeyValueStyleRuleTest extends RuleTestCase
 {
     protected function getRule(): Rule
     {
-        return self::getContainer()->getByType(DoctrineKeyValueStyleRule::class);
+        $rule = self::getContainer()->getByType(DoctrineKeyValueStyleRule::class);
+        $rule->classMethods[] = ['staabm\PHPStanDba\Tests\Fixture\Connection', 'assembleNoArrays', []];
+        $rule->classMethods[] = ['staabm\PHPStanDba\Tests\Fixture\Connection', 'assembleOneArray', [1]];
+        $rule->classMethods[] = ['staabm\PHPStanDba\Tests\Fixture\Connection', 'assembleTwoArrays', [1,2]];
+        return $rule;
     }
 
     public static function getAdditionalConfigFiles(): array

tests/rules/SyntaxErrorInPreparedStatementMethodRuleTest.php

@@ -18,8 +18,11 @@ class SyntaxErrorInPreparedStatementMethodRuleTest extends RuleTestCase
 {
     protected function getRule(): Rule
     {
-        return self::getContainer()->getByType(SyntaxErrorInPreparedStatementMethodRule::class);
-    }
+        $rule = self::getContainer()->getByType(SyntaxErrorInPreparedStatementMethodRule::class);
+        $rule->classMethods[] ='staabm\PHPStanDba\Tests\Fixture\Connection::preparedQuery';
+        $rule->classMethods[] ='staabm\PHPStanDba\Tests\Fixture\PreparedStatement::__construct';
+        $rule->classMethods[] ='staabm\PHPStanDba\Tests\Fixture\BaseQueryClass::doQuery';
+        return $rule;    }
 
     public static function getAdditionalConfigFiles(): array
     {

tests/rules/SyntaxErrorInPreparedStatementMethodSubclassedRuleTest.php

@@ -10,6 +10,7 @@
 use staabm\PHPStanDba\QueryReflection\PdoMysqlQueryReflector;
 use staabm\PHPStanDba\QueryReflection\PdoPgSqlQueryReflector;
 use staabm\PHPStanDba\Rules\SyntaxErrorInPreparedStatementMethodRule;
+use staabm\PHPStanDba\Rules\SyntaxErrorInQueryMethodRule;
 
 /**
  * @extends RuleTestCase<SyntaxErrorInPreparedStatementMethodRule>
@@ -18,7 +19,11 @@ class SyntaxErrorInPreparedStatementMethodSubclassedRuleTest extends RuleTestCas
 {
     protected function getRule(): Rule
     {
-        return self::getContainer()->getByType(SyntaxErrorInPreparedStatementMethodRule::class);
+        $rule = self::getContainer()->getByType(SyntaxErrorInPreparedStatementMethodRule::class);
+        $rule->classMethods[] ='staabm\PHPStanDba\Tests\Fixture\Connection::preparedQuery';
+        $rule->classMethods[] ='staabm\PHPStanDba\Tests\Fixture\PreparedStatement::__construct';
+        $rule->classMethods[] ='staabm\PHPStanDba\Tests\Fixture\BaseQueryClass::doQuery';
+        return $rule;
     }
 
     public static function getAdditionalConfigFiles(): array

tests/rules/SyntaxErrorInQueryMethodSubclassedRuleTest.php

@@ -18,7 +18,9 @@ class SyntaxErrorInQueryMethodSubclassedRuleTest extends RuleTestCase
 {
     protected function getRule(): Rule
     {
-        return self::getContainer()->getByType(SyntaxErrorInQueryMethodRule::class);
+        $rule = self::getContainer()->getByType(SyntaxErrorInQueryMethodRule::class);
+        $rule->classMethods[] = 'staabm\PHPStanDba\Tests\Fixture\BaseQueryClass::doQuery#0';
+        return $rule;
     }
 
     public static function getAdditionalConfigFiles(): array