chore: merged migration / lint fixes

Author: dervoeti

backend/application/commons/migrations/0019_merge_20250727_1457.py

@@ -0,0 +1,13 @@
+# Generated by Django 5.2.4 on 2025-07-27 12:57
+
+from django.db import migrations
+
+
+class Migration(migrations.Migration):
+
+    dependencies = [
+        ("commons", "0017_settings_periodic_task_max_entries"),
+        ("commons", "0018_merge_20250512_1218"),
+    ]
+
+    operations = []

backend/application/core/services/assessment.py

@@ -71,12 +71,12 @@ def save_assessment(
         Assessment_Status.ASSESSMENT_STATUS_AUTO_APPROVED,
     ):
         _update_observation(
-            observation,
-            new_severity,
-            new_status,
-            new_vex_justification,
-            new_vex_remediations,
-            new_risk_acceptance_expiry_date,
+            observation=observation,
+            new_severity=new_severity,
+            new_status=new_status,
+            new_vex_justification=new_vex_justification,
+            new_vex_remediations=new_vex_remediations,
+            new_risk_acceptance_expiry_date=new_risk_acceptance_expiry_date,
         )
 
         create_observation_log(
@@ -106,6 +106,7 @@ def save_assessment(
 
 
 def _update_observation(
+    *,
     observation: Observation,
     new_severity: Optional[str],
     new_status: Optional[str],
@@ -212,12 +213,12 @@ def assessment_approval(observation_log: Observation_Log, assessment_status: str
         Assessment_Status.ASSESSMENT_STATUS_AUTO_APPROVED,
     ):
         _update_observation(
-            observation_log.observation,
-            observation_log.severity,
-            observation_log.status,
-            observation_log.vex_justification,
-            observation_log.vex_remediations,
-            observation_log.risk_acceptance_expiry_date,
+            observation=observation_log.observation,
+            new_severity=observation_log.severity,
+            new_status=observation_log.status,
+            new_vex_justification=observation_log.vex_justification,
+            new_vex_remediations=observation_log.vex_remediations,
+            new_risk_acceptance_expiry_date=observation_log.risk_acceptance_expiry_date,
         )
 
         check_security_gate(observation_log.observation.product)

backend/application/core/services/observation_log.py

@@ -6,7 +6,7 @@
 from application.core.models import Observation, Observation_Log
 
 
-def create_observation_log(
+def create_observation_log(  # pylint: disable=too-many-arguments
     *,
     observation: Observation,
     severity: str,

backend/application/core/services/observations_bulk_actions.py

@@ -27,7 +27,7 @@
 )
 
 
-def observations_bulk_assessment(
+def observations_bulk_assessment(  # pylint: disable=too-many-arguments
     *,
     product: Optional[Product],
     new_severity: str,

backend/application/import_observations/parsers/cyclone_dx/parser.py

@@ -271,8 +271,7 @@ def parse_version(version: str) -> tuple[int, ...]:
                                 minor_diff = abs(v2[1] - v1[1])
                                 patch_diff = abs(v2[2] - v1[2])
                                 upgrade_impact_score = major_diff * 100 + minor_diff * 10 + patch_diff
-                                if upgrade_impact_score < lowest_impact_score:
-                                    lowest_impact_score = upgrade_impact_score
+                                lowest_impact_score = min(lowest_impact_score, upgrade_impact_score)
                             upgrade_impact_score = lowest_impact_score
 
                         observation = Observation(

backend/application/rules/services/rule_engine.py

@@ -54,7 +54,7 @@ def __init__(self, product: Product):
 
         self.product = product
 
-    def apply_rules_for_observation(self, observation: Observation) -> None:
+    def apply_rules_for_observation(self, observation: Observation) -> None:  # pylint: disable=too-many-branches
         if observation.current_status != Status.STATUS_OPEN:
             return
 
@@ -181,7 +181,7 @@ def _check_regex(self, pattern: str, value: str) -> bool:
         compiled_pattern = re.compile(pattern, re.IGNORECASE)
         return compiled_pattern.match(value) is not None
 
-    def _write_observation_log(
+    def _write_observation_log(  # pylint: disable=too-many-arguments,too-many-branches
         self,
         *,
         observation: Observation,