Skip to content

Wrong casing for metadataManager field in CRD #1033

Description

@sbernauer

Affected Stackable version

0.0.0-dev

Current and expected behavior

Per Kubernetes convention, scalar values are PascalCase (e.g. see ClusterIp, NodePort etc.).
In

#[serde(rename_all = "lowercase")]
pub enum MetadataManager {
we define them as zookeeper and kraft, although according to the convention they should be ZooKeeper and KRaft.

Sadly this is a breaking change, but for now we can accept both variants (lower and Pascal case), which is non-breaking :)

Activity

  1. razvan commented on Sep 29, 2026

    @razvan
    Member

    I missed this sorry. My bad.

    Is it really worth the breaking change considering this field will eventually become obsolete and eventually deleted?

  2. sbernauer commented on Sep 29, 2026

    @sbernauer
    MemberAuthor

    No worries! Yeah, for now we only do the non-breaking change of accepting PascalCase variants I'd say

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions