noteAllDescendants also disables push notifications for direct replies

[ekzyis]

Is there an existing issue for this?

• I have searched the existing issues

Describe the bug

We currently only send out push notifications for replies if noteAllDescendants is set:

stacker.news/lib/webPush.js

Lines 37 to 54 in b28407e

	const createUserFilter = (tag) => {
	// filter users by notification settings
	const tagMap = {
	REPLY: 'noteAllDescendants',
	MENTION: 'noteMentions',
	ITEM_MENTION: 'noteItemMentions',
	TIP: 'noteItemSats',
	FORWARDEDTIP: 'noteForwardedSats',
	REFERRAL: 'noteInvites',
	INVITE: 'noteInvites',
	EARN: 'noteEarning',
	DEPOSIT: 'noteDeposits',
	WITHDRAWAL: 'noteWithdrawals',
	STREAK: 'noteCowboyHat'
	}
	const key = tagMap[tag.split('-')[0]]
	return key ? { user: { [key]: true } } : undefined
	}

However, direct replies always show up in /notifications so push notifications are inconsistent with the notifications we show there.

To fix this, we would need to always send a push notification for every reply.

Screenshots

No response

Steps To Reproduce

1. Enable push notifications
2. Disable someone replies to someone who replied to me in settings
3. Reply to yourself with anon
4. No push notification received but notification in /notifications

Expected behavior

Push notification received

Logs

No response

Device information

No response

Additional context

No response