Skip to content

Commit c75e6b0

Browse files
committed
remove redundant volume group task
1 parent 366749d commit c75e6b0

File tree

6 files changed

+10
-18
lines changed

6 files changed

+10
-18
lines changed

README.md

+7-5
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,7 @@ installed.
8181
Dependencies
8282
------------
8383

84-
None
84+
* [The LVM role](https://github.com/mrlesmithjr/ansible-manage-lvm) You can install it using `ansible-galaxy install -r requirements.yml --roles-p ../community`
8585

8686
Example Playbook
8787
----------------
@@ -91,6 +91,11 @@ Example Playbook
9191
hosts: all
9292
roles:
9393
- role: stackhpc.libvirt-host
94+
lvm_groups: # see according properties on [The LVM role](https://github.com/mrlesmithjr/ansible-manage-lvm)
95+
- vgname: libvirtvg
96+
disks:
97+
- /dev/sdb1
98+
create: true
9499
libvirt_host_pools:
95100
- name: my-pool
96101
type: dir
@@ -101,10 +106,7 @@ Example Playbook
101106
group: my-group
102107
- name: lvm_pool
103108
type: lvm2
104-
source: vg1
105-
target: /dev/vg1
106-
pvs:
107-
- /dev/sda3
109+
source: libvirtvg
108110
libvirt_host_networks:
109111
- name: br-example
110112
mode: bridge

molecule/default/converge.yml

+2-3
Original file line numberDiff line numberDiff line change
@@ -4,11 +4,10 @@
44
vars:
55
manage_lvm: true
66
lvm_groups:
7-
- vgname: libvirtpool
7+
- vgname: libvirt_vg
88
disks:
99
- /dev/sdb1
1010
create: true
11-
lvnames: []
1211
users_group_list:
1312
- name: libvirt
1413
systemusers_user_list:
@@ -18,7 +17,7 @@
1817
libvirt_host_pools:
1918
- name: libvirt_vg
2019
type: lvm2
21-
source: libvirtpool
20+
source: libvirt_vg
2221
libvirt_host_networks:
2322
- name: ansible-virtualization-bridge
2423
mode: bridge
Binary file not shown.
Binary file not shown.

molecule/kvm/converge.yml

+1-2
Original file line numberDiff line numberDiff line change
@@ -4,11 +4,10 @@
44
vars:
55
manage_lvm: true
66
lvm_groups:
7-
- vgname: libvirtpool
7+
- vgname: libvirt_vg
88
disks:
99
- /dev/vdb
1010
create: true
11-
lvnames: []
1211
users_group_list:
1312
- name: libvirt
1413
systemusers_user_list:

tasks/pools.yml

-8
Original file line numberDiff line numberDiff line change
@@ -18,14 +18,6 @@
1818
with_items: "{{ libvirt_host_pools }}"
1919
become: True
2020

21-
- name: Ensure libvirt lvm2 storage pool directories exist
22-
lvg:
23-
vg: "{{ item.source }}"
24-
pvs: "{{ item.pvs }}"
25-
when: item.type == "lvm2" and item.pvs is defined
26-
with_items: "{{ libvirt_host_pools }}"
27-
become: True
28-
2921
- name: Ensure libvirt storage pools are defined
3022
virt_pool:
3123
name: "{{ item.name }}"

0 commit comments

Comments
 (0)