set FQCN on all calls

Author: Tcharl

.github/workflows/molecule.yml

@@ -33,6 +33,7 @@ jobs:
           sudo apt update
           sudo apt -y install python3-setuptools python3 python3-pip
           pip3 install wheel
+          pip3 install ansible-compat==0.5.0
           pip3 install ansible molecule testinfra yamllint ansible-lint flake8 molecule-vagrant
 
       - name: molecule lint

.travis.yml

@@ -33,6 +33,7 @@ install:
   - vagrant plugin install vagrant-libvirt
   - pip install wheel pyopenssl
   - pip install netaddr python-vagrant yamllint testinfra flake8
+  - pip install ansible-compat==0.5.0 # see https://github.com/ansible-community/molecule/issues/3404
   - pip install ansible ansible-lint
   - pip install molecule molecule-vagrant python-vagrant
   - sudo chmod o+rwx /var/run/libvirt/libvirt-sock

tasks/config.yml

@@ -2,7 +2,7 @@
 # Configure services - runs after the install stage
 
 - name: Create directory for libvirt socket
-  file:
+  ansible.builtin.file:
     state: directory
     path: "{{ libvirt_host_socket_dir }}"
     owner: root
@@ -12,7 +12,7 @@
   when: libvirt_host_socket_dir | length > 0
 
 - name: Process lineinfile rules
-  lineinfile: "{{ rule.args }}"
+  ansible.builtin.lineinfile: "{{ rule.args }}"
   become: true
   loop: "{{ libvirt_host_lineinfile_extra_rules | default([]) }}"
   loop_control:
@@ -22,7 +22,7 @@
     - restart libvirt
 
 - name: Ensure configuration files exist
-  template:
+  ansible.builtin.template:
     src: "{{ item.src }}"
     dest: "{{ item.dest }}"
     owner: root
@@ -47,7 +47,7 @@
     - restart libvirt
 
 - name: Create systemd drop-in directory for socket listen address
-  file:
+  ansible.builtin.file:
     path: "/etc/systemd/system/{{ item.service }}.d"
     state: directory
     owner: root
@@ -64,7 +64,7 @@
     _libvirt_listen_stream: "{{ item.listen_address }}"
 
 - name: Configure socket listen address
-  template:
+  ansible.builtin.template:
     src: socket.j2
     dest: "/etc/systemd/system/{{ item.service }}.d/listen-address.conf"
     owner: root
@@ -84,7 +84,7 @@
     - restart libvirt
 
 - name: Create directory for TLS certificates and keys
-  file:
+  ansible.builtin.file:
     path: "{{ item }}"
     state: directory
     owner: root
@@ -101,7 +101,7 @@
     - libvirt_host_tls_listen | bool
 
 - name: Copy TLS certificates and keys
-  copy:
+  ansible.builtin.copy:
     content: "{{ _libvirt_loop_item.content }}"
     dest: "{{ _libvirt_loop_item.dest }}"
     owner: root
@@ -119,7 +119,7 @@
   notify: restart libvirt
 
 - name: Ensure libvirt SASL user exists
-  shell:
+  ansible.builtin.shell:
     cmd: >
       set -o pipefail &&
       echo {{ item.password }} |
@@ -132,10 +132,10 @@
   when: libvirt_host_enable_sasl_support | bool
 
 - name: Flush handlers
-  meta: flush_handlers
+  ansible.builtin.meta: flush_handlers
 
 - name: Ensure the libvirt daemon is started and enabled
-  service:
+  ansible.builtin.service:
     name: "{{ item.service }}"
     state: "{{ item.enabled | bool | ternary('started', 'stopped') }}"
     enabled: "{{ item.enabled | bool }}"

tasks/install-client.yml

@@ -1,6 +1,6 @@
 ---
 - name: Ensure libvirt client packages are installed
-  package:
+  ansible.builtin.package:
     name: "{{ libvirt_host_libvirt_packages_client | select | list }}"
     state: present
   register: result

tasks/install-daemon.yml

@@ -8,12 +8,12 @@
   #
   # The core team had a a change of heart and it is actually being preserved:
   # https://github.com/ansible/ansible/pull/43798
-  yum_repository: "{{ item }}"
+  ansible.builtin.yum_repository: "{{ item }}"
   loop: "{{ libvirt_host_custom_yum_repos | default([]) }}"
   become: true
 
 - name: Ensure libvirt packages are installed
-  package:
+  ansible.builtin.package:
     name: "{{ libvirt_host_libvirt_packages | select | list }}"
     state: present
   register: result
@@ -23,7 +23,7 @@
 
 # NOTE: QEMU emulators are available in EPEL on CentOS 7.
 - name: Ensure the EPEL repository is enabled
-  yum:
+  ansible.builtin.yum:
     name: epel-release
     state: present
   register: result
@@ -36,7 +36,7 @@
     - libvirt_host_qemu_emulators | length > 0
 
 - name: Ensure QEMU emulator packages are installed
-  package:
+  ansible.builtin.package:
     name: "{{ package }}"
     state: present
   loop: "{{ libvirt_host_qemu_emulators | flatten(levels=1) }}"

tasks/main.yml

@@ -1,16 +1,16 @@
 ---
-- import_tasks: prelude.yml
-- import_tasks: validate.yml
+- ansible.builtin.include_tasks: prelude.yml
+- ansible.builtin.include_tasks: validate.yml
 - name: Include install-daemon.yml
-  include_tasks: install-daemon.yml
+  ansible.builtin.include_tasks: install-daemon.yml
   when: libvirt_host_install_daemon | bool
 - name: Include install-client.yml
-  include_tasks: install-client.yml
+  ansible.builtin.include_tasks: install-client.yml
   when:
     - not libvirt_host_install_daemon | bool
     - libvirt_host_install_client | bool
 - name: Run post-install stage
-  include_tasks: "{{ post_install_path }}"
+  ansible.builtin.include_tasks: "{{ post_install_path }}"
   with_first_found:
     - files:
         - post-install-{{ ansible_facts.distribution }}.yml
@@ -19,14 +19,14 @@
   loop_control:
     loop_var: post_install_path
 - name: Include config.yml
-  include_tasks: config.yml
+  ansible.builtin.include_tasks: config.yml
   when: libvirt_host_install_daemon | bool
 - name: Include client-config.yml
-  include_tasks: client-config.yml
+  ansible.builtin.include_tasks: client-config.yml
   when: libvirt_host_install_client | bool
 - name: Include pools.yml
-  include_tasks: pools.yml
+  ansible.builtin.include_tasks: pools.yml
   when: libvirt_host_pools | length > 0
 - name: Include networks.yml
-  include_tasks: networks.yml
+  ansible.builtin.include_tasks: networks.yml
   when: libvirt_host_networks | length > 0

tasks/networks.yml

@@ -1,6 +1,6 @@
 ---
 - name: Ensure libvirt networks are defined
-  virt_net:
+  community.libvirt.virt_net:
     name: "{{ item.name }}"
     command: define
     xml: "{{ item.xml | default(lookup('template', 'network.xml.j2')) }}"
@@ -9,15 +9,15 @@
   become: True
 
 - name: Ensure libvirt networks are started on boot
-  virt_net:
+  community.libvirt.virt_net:
     name: "{{ item.name }}"
     autostart: yes
     uri: "{{ libvirt_host_uri | default(omit, true) }}"
   with_items: "{{ libvirt_host_networks }}"
   become: True
 
 - name: Ensure libvirt networks are active
-  virt_net:
+  community.libvirt.virt_net:
     name: "{{ item.name }}"
     state: active
     uri: "{{ libvirt_host_uri | default(omit, true) }}"

tasks/pools.yml

@@ -1,14 +1,14 @@
 ---
 - name: Include lvm role to create VG
-  include_role:
+  ansible.builtin.include_role:
     name: mrlesmithjr.manage-lvm
   when:
     - manage_lvm is defined
     - manage_lvm
     - libvirt_host_pools |  map(attribute='type') | select('match', '^lvm2$') | join(',') | length > 0
 
 - name: Ensure libvirt dir storage pool directories exist
-  file:
+  ansible.builtin.file:
     path: "{{ item.path }}"
     owner: "{{ item.owner }}"
     group: "{{ item.group }}"
@@ -19,15 +19,15 @@
   become: True
 
 - name: include rbd.yml
-  include_tasks:
+  ansible.builtin.include_tasks:
     file: rbd.yml
     apply:
       become: True
   when: item.type == "rbd"
   loop: "{{ libvirt_host_pools | flatten(levels=1) }}"
 
 - name: Ensure libvirt storage pools are defined
-  virt_pool:
+  community.libvirt.virt_pool:
     name: "{{ item.name }}"
     command: define
     xml: "{{ item.xml | default(lookup('template', 'pool.xml.j2')) }}"
@@ -36,7 +36,7 @@
   become: True
 
 - name: Check libvirt directory storage pool status
-  virt_pool:
+  community.libvirt.virt_pool:
     name: "{{ item.name }}"
     command: status
     uri: "{{ libvirt_host_uri | default(omit, true) }}"
@@ -46,7 +46,7 @@
   register: pool_status
 
 - name: Ensure libvirt directory storage pools are built
-  virt_pool:
+  community.libvirt.virt_pool:
     name: "{{ item.item.name }}"
     command: build
     uri: "{{ libvirt_host_uri | default(omit, true) }}"
@@ -57,15 +57,15 @@
   become: True
 
 - name: Ensure libvirt storage pools are active
-  virt_pool:
+  community.libvirt.virt_pool:
     name: "{{ item.name }}"
     state: active
     uri: "{{ libvirt_host_uri | default(omit, true) }}"
   loop: "{{ libvirt_host_pools | flatten(levels=1) }}"
   become: True
 
 - name: Ensure libvirt storage pools are started on boot
-  virt_pool:
+  community.libvirt.virt_pool:
     name: "{{ item.name }}"
     autostart: yes
     uri: "{{ libvirt_host_uri | default(omit, true) }}"

tasks/post-install-Debian.yml

@@ -8,13 +8,13 @@
 # skip being set to true. This is undeseriable so we have to
 # put it behind an include (a block doesn't work).
 - name: Check if /etc/default/libvirt-bin exists
-  stat:
+  ansible.builtin.stat:
     path: /etc/default/libvirt-bin
   register: libvirt_bin_stat
   tags: vars
 
 - name: Determine path to libvirt environment file
-  set_fact:
+  ansible.builtin.set_fact:
     libvirt_host_lineinfile_extra_rules:
       - args:
           path: "{{ libvirt_env_path }}"
@@ -27,7 +27,7 @@
   tags: vars
 
 - name: Configure libvirt QEMU apparmor profile template
-  lineinfile:
+  ansible.builtin.lineinfile:
     path: "/etc/apparmor.d/libvirt/TEMPLATE.qemu"
     insertbefore: "^}"
     line: "  {{ item.path }}/** rwk,"

tasks/prelude.yml

@@ -2,7 +2,7 @@
 # This file is intended to be included at the beginning of a playbook.
 
 - name: gather os specific variables
-  include_vars: "{{ item }}"
+  ansible.builtin.include_vars: "{{ item }}"
   with_first_found:
     - "{{ ansible_facts.distribution }}-{{ ansible_facts.distribution_major_version }}.yml"
     - "{{ ansible_facts.distribution }}.yml"

tasks/rbd.yml

@@ -1,35 +1,35 @@
 ---
 
 - name: Install additional packages for rbd support
-  package:
+  ansible.builtin.package:
     name: "{{ libvirt_host_packages_rbd_volume_pool | flatten(levels=1) }}"
     state: present
   notify: restart libvirt
 
 - name: Create temporary file for Ceph secret
-  tempfile:
+  ansible.builtin.tempfile:
     state: file
     suffix: .xml
   register: secret_tempfile
 
 - name: Send Ceph secret
-  template:
+  ansible.builtin.template:
     mode: 0640
     src: ceph_secret.xml.j2
     dest: "{{ secret_tempfile.path }}"
 
 - name: Define Ceph secret
-  command: "virsh secret-define {{ secret_tempfile.path }}"
+  ansible.builtin.command: "virsh secret-define {{ secret_tempfile.path }}"
   changed_when: false
 
 - name: Set Ceph secret value
-  command: "virsh secret-set-value {{ item.name | to_uuid }} {{ item.passphrase }}"
+  ansible.builtin.command: "virsh secret-set-value {{ item.name | to_uuid }} {{ item.passphrase }}"
   changed_when: false
 
 - name: Delete temporary file
-  file:
+  ansible.builtin.file:
     path: "{{ secret_tempfile.path }}"
     state: absent
 
 - name: Flush handlers
-  meta: flush_handlers
+  ansible.builtin.meta: flush_handlers

tasks/validate.yml

@@ -1,17 +1,17 @@
 ---
 - name: Verify that Virtualization Technology (VT) is enabled
-  command: grep -c -E 'svm|vmx' /proc/cpuinfo
+  ansible.builtin.command: grep -c -E 'svm|vmx' /proc/cpuinfo
   check_mode: False
   changed_when: False
   failed_when: False
   register: result
 
 - name: Set a fact about whether Virtualization Technology (VT) is enabled
-  set_fact:
+  ansible.builtin.set_fact:
     libvirt_host_vt_enabled: "{{ result.rc == 0 }}"
 
 - name: Notify if Virtualization Technology (VT) is disabled
-  debug:
+  ansible.builtin.debug:
     msg: >
       Virtualization Technology (VT) is currently disabled. Please enable VT
       before running this role again.
@@ -20,7 +20,7 @@
     - not libvirt_host_vt_enabled
 
 - name: Fail if Virtualization Technology (VT) is disabled
-  fail:
+  ansible.builtin.fail:
     msg: >
       Virtualization Technology (VT) is currently disabled. Please enable VT
       before running this role again.
@@ -29,7 +29,7 @@
     - not libvirt_host_vt_enabled
 
 - name: Fail if SASL password is not defined
-  fail:
+  ansible.builtin.fail:
     msg: >
       One or more SASL passwords in 'libvirt_host_sasl_credentials' are not
       defined