-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
codegate garbles output on main #1250
Labels
Comments
The bug is in the secret unredaction step. |
jhrozek
added a commit
that referenced
this issue
Mar 10, 2025
Our PII refaction format is `#UUID#`. Our code was finding an opening #, then checking for a closing matching # or end of the output. For copilot, however, this meant that we were buffering the whole file, because the filename comes in this format: ``` ``` This means we would keep searching for the closing hash which never came. Instead, buffer only as long as the context between the hashes can reasonably be a UUID. Fixes: #1250
jhrozek
added a commit
that referenced
this issue
Mar 12, 2025
Our PII refaction format is `#UUID#`. Our code was finding an opening #, then checking for a closing matching # or end of the output. For copilot, however, this meant that we were buffering the whole file, because the filename comes in this format: ``` ``` This means we would keep searching for the closing hash which never came. Instead, buffer only as long as the context between the hashes can reasonably be a UUID. Fixes: #1250
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Found when debugging our llmlite-less branch, but turns out this bug is on main as well
The text was updated successfully, but these errors were encountered: