Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

codegate garbles output on main #1250

Closed
jhrozek opened this issue Mar 7, 2025 · 1 comment · Fixed by #1261
Closed

codegate garbles output on main #1250

jhrozek opened this issue Mar 7, 2025 · 1 comment · Fixed by #1261
Assignees
Labels

Comments

@jhrozek
Copy link
Contributor

jhrozek commented Mar 7, 2025

Found when debugging our llmlite-less branch, but turns out this bug is on main as well

Image
@jhrozek
Copy link
Contributor Author

jhrozek commented Mar 7, 2025

The bug is in the secret unredaction step.

@jhrozek jhrozek self-assigned this Mar 10, 2025
jhrozek added a commit that referenced this issue Mar 10, 2025
Our PII refaction format is `#UUID#`. Our code was finding an opening #,
then checking for a closing matching # or end of the output. For
copilot, however, this meant that we were buffering the whole file,
because the filename comes in this format:

```
```

This means we would keep searching for the closing hash which never
came. Instead, buffer only as long as the context between the hashes can
reasonably be a UUID.

Fixes: #1250
jhrozek added a commit that referenced this issue Mar 12, 2025
Our PII refaction format is `#UUID#`. Our code was finding an opening #,
then checking for a closing matching # or end of the output. For
copilot, however, this meant that we were buffering the whole file,
because the filename comes in this format:

```
```

This means we would keep searching for the closing hash which never
came. Instead, buffer only as long as the context between the hashes can
reasonably be a UUID.

Fixes: #1250
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant