Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Incorrect fee estimation causes sBTC to be locked up indefinitely #746

Open
technovision99 opened this issue Oct 31, 2024 · 2 comments
Labels
flagged by AR Issue / bug / suggestion filed by Asymmetric Research P1 High Priority

Comments

@technovision99
Copy link

(High) Incorrect fee estimation causes sBTC to be locked up indefinitely

1. Description

The fix in #498 does indeed correctly lock up the max-fee from the user however our concern is that the code does not currently have a way to call reject-withdrawal-request as per #478 and #568. As a result if fee estimation fails for whatever reason (including a fee of 0) a user's sBTC will be locked indefinitely.

This issue should be resolved once calls to reject-withdrawal-request is implemented and called if the request's max-fee is not enough to pay for submitting the transaction fee on bitcoin.

@djordon
Copy link
Collaborator

djordon commented Oct 31, 2024

Good call out. I think this is the same issue highlighted in #620, and I think the fix will be us doing one of the proposals listed there.

@aldur aldur added the flagged by AR Issue / bug / suggestion filed by Asymmetric Research label Nov 4, 2024
@aldur aldur added this to sBTC Nov 4, 2024
@github-project-automation github-project-automation bot moved this to Needs Triage in sBTC Nov 4, 2024
@aldur aldur added the P1 High Priority label Nov 4, 2024
@aldur aldur added this to the sBTC Release Ready milestone Nov 4, 2024
@djordon djordon moved this from Needs Triage to Todo in sBTC Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flagged by AR Issue / bug / suggestion filed by Asymmetric Research P1 High Priority
Projects
Status: Todo
Development

No branches or pull requests

4 participants
@aldur @djordon @technovision99 and others