Merge pull request #5921 from fdefelici/fix/avoid-mock-mine-no-utxo-log

avoid "No UTXOs" warn log when in mock_mining mode

Author: kantai

CHANGELOG.md

@@ -14,6 +14,7 @@ and this project adheres to the versioning scheme outlined in the [README.md](RE
 
 - When a miner times out waiting for signatures, it will re-propose the same block instead of building a new block ([#5877](https://github.com/stacks-network/stacks-core/pull/5877))
 - Improve tenure downloader trace verbosity applying proper logging level depending on the tenure state ("debug" if unconfirmed, "info" otherwise) ([#5871](https://github.com/stacks-network/stacks-core/issues/5871))
+- Remove warning log about missing UTXOs when a node is configured as `miner` with `mock_mining` mode enabled ([#5841](https://github.com/stacks-network/stacks-core/issues/5841)) 
 
 ## [3.1.0.0.7]
 

testnet/stacks-node/src/burnchains/bitcoin_regtest_controller.rs

@@ -744,11 +744,6 @@ impl BitcoinRegtestController {
         utxos_to_exclude: Option<UTXOSet>,
         block_height: u64,
     ) -> Option<UTXOSet> {
-        // if mock mining, do not even bother requesting UTXOs
-        if self.config.get_node_config(false).mock_mining {
-            return None;
-        }
-
         let pubk = if self.config.miner.segwit && epoch_id >= StacksEpochId::Epoch21 {
             let mut p = *public_key;
             p.set_compressed(true);
@@ -1693,6 +1688,11 @@ impl BitcoinRegtestController {
             // in RBF, you have to consume the same UTXOs
             utxos
         } else {
+            // if mock mining, do not even bother requesting UTXOs
+            if self.config.node.mock_mining {
+                return Err(BurnchainControllerError::NoUTXOs);
+            }
+
             // Fetch some UTXOs
             let addr = self.get_miner_address(epoch_id, public_key);
             match self.get_utxos(