Interrupt miner when Stacks tip changes #5751
Labels
optimization
Update speed, efficiency, or quality of a feature.
Comments
obycode
added
the
optimization
aldur
changed the title
obycode
added a commit
that referenced
this issue
Feb 4, 2025
This could happen at the beginning of a tenure, if the miner for tenure T+1 proposes its first block before it sees the last block from tenure T, so the block it proposed is reorging that last block. Once it sees this block, it should immediately stop waiting for signatures and instead build a new block off of the new tip. Fixes: #5751
|
Fixed with #5801 |
github-project-automation
bot
moved this from Status: 🆕 New
to Status: ✅ Done
in Stacks Core Eng
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This is an optimization to improve the time it takes to mine the first valid block in a tenure. When mining a tenure, the miner thread should get interrupted when the tip advances. The way it currently works, at the beginning of a tenure, the miner will often start mining its first block before it sees the last block of the previous tenure. If that last block is accepted and the miner's tip advances, the miner finishes building the block and proposing it to the signers any way. Instead, the miner should stop building its current block, or stop waiting for signatures, since it knows that it will be rejected by 70+% of the signers for not confirming that last block. It can then quickly build a new block atop the new tip.
The text was updated successfully, but these errors were encountered: