Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure we're sending eth correctly #49

Open
lalexgap opened this issue Dec 1, 2021 · 0 comments
Open

Ensure we're sending eth correctly #49

lalexgap opened this issue Dec 1, 2021 · 0 comments

Comments

@lalexgap
Copy link
Contributor

lalexgap commented Dec 1, 2021

LGTM, but:

  1. The linked page dates this recommendation from Dec 2019. Described rationale seems good to me, but two years may as well be 30 years.
  2. This probably belongs in a separate PR

Originally posted by @NiloCK in #45 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@lalexgap