Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge fildev-payment-client (demo feature branch) to main #1814

Closed
6 tasks done
geoknee opened this issue Oct 6, 2023 · 0 comments
Closed
6 tasks done

Merge fildev-payment-client (demo feature branch) to main #1814

geoknee opened this issue Oct 6, 2023 · 0 comments
Assignees

Comments

@geoknee
Copy link
Contributor

geoknee commented Oct 6, 2023

It's this PR #1672

  • Update netlify config to deploy the demo site from main branch (and skip if the relevant package was not changed).
  • perform a final review of the entire changeset (bearing in mind it has already been reviewed already, although potentially under greater time pressure than usual).
  • consider whether we need multiple bootpeers specified (I think it should be just iris)
  • consider whether we want to keep any of the code in a separate branch and not merge to main (The advantages don't seem huge to me, and I think we should just merge it all, and then we can reconfigure things later if we want)
  • merge outstanding PRs into main when their base gets automatically changed
  • ensure demo still works
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants