Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add RPCProvider unique ID to HealthChecker chain statuses #6266

Open
friofry opened this issue Jan 17, 2025 · 0 comments · May be fixed by #6362
Open

Add RPCProvider unique ID to HealthChecker chain statuses #6266

friofry opened this issue Jan 17, 2025 · 0 comments · May be fixed by #6362
Assignees
@friofry
Labels
wallet-team

Comments

@friofry
Copy link
Contributor

friofry commented Jan 17, 2025

As @dlipicar suggested, it would be good to have a link between HealthChecker statuses and RPCProviders we store in networks.

HealthChecker aggregates RPC client states per chain and per provider. Currently, it stores a map of provider statuses with a circuitName key, which is not convenient for mapping status to actual RPC providers.

Ideally, the RPCProvider should have a unique ID. Currently it's Name + ChainID
@friofry friofry changed the title Add RPCProvider Name to HealthChecker results Add RPCProvider unique ID to HealthChecker chain statuses Jan 17, 2025
@friofry friofry self-assigned this Jan 17, 2025
@friofry friofry moved this to In Progress in Status Desktop/Mobile Board Feb 21, 2025
friofry added a commit that referenced this issue Feb 25, 2025
@friofry
chore(rpc-providers)_: add helper methods to RpcProvider
62e3054 
fixes #6266
friofry added a commit that referenced this issue Feb 25, 2025
@friofry
chore(rpc-providers)_: move rps_limiter logic from chain/client.go to…
5b1315a 
… rps_limited_eth_client.go

fixes #6266
friofry added a commit that referenced this issue Feb 25, 2025
@friofry
chore(rpc-providers)_: util function to dial a rpc provider
ca900b1 
fixes #6266
friofry added a commit that referenced this issue Feb 25, 2025
@friofry
chore(rpc-providers)_: add chain id to provider status
1a6f084 
fixes #6266
friofry added a commit that referenced this issue Feb 25, 2025
@friofry
chore(rpc-providers)_: add circuit, provider name to RpsLimitedEthCli…
43d6c07 
…ent interface

fixes #6266
friofry added a commit that referenced this issue Feb 25, 2025
@friofry
chore(rpc-providers)_: circuit breaker sends statuses with provider name
aed0215 
* do not use circuit breaker if the circuit name is empty

fixes #6266
friofry added a commit that referenced this issue Feb 25, 2025
@friofry
chore(rpc-providers)_: log method name in the rpc client error
dfd00b2 
fixes #6266
friofry added a commit that referenced this issue Feb 25, 2025
@friofry
chore(rpc-providers)_: remove ProviderCallStatus struct
8e3edd8 
fixes #6266
friofry added a commit that referenced this issue Feb 25, 2025
@friofry
chore(rpc-providers)_: fix conversion of LastError to string
e5f4ec7 
fixes #6266
friofry added a commit that referenced this issue Feb 25, 2025
@friofry
chore(rpc-providers)_: add chainId to provider status
071941f 
fixes #6266
@friofry friofry linked a pull request Feb 25, 2025 that will close this issue
Open
friofry added a commit that referenced this issue Feb 25, 2025
@friofry
chore(rpc-providers)_: remove unused function
c79dddc 
fixes #6266
friofry added a commit that referenced this issue Feb 26, 2025
@friofry
chore(rpc-providers)_: address PR feedback
f24af90 
fixes #6266
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@friofry friofry

Labels
wallet-team
Projects
Status Desktop/Mobile Board
Status: In Progress
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve rpc errors logging status-im/status-go
1 participant
@friofry