Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG]: CI benchmark workflows cannot currently handle Cephes benchmarks #8

Closed
Planeshifter opened this issue Feb 13, 2025 · 3 comments · Fixed by stdlib-js/stdlib#5378
Closed

[BUG]: CI benchmark workflows cannot currently handle Cephes benchmarks #8

Planeshifter opened this issue Feb 13, 2025 · 3 comments · Fixed by stdlib-js/stdlib#5378
Assignees
@Planeshifter
Labels
Bug Task to fix a bug. difficulty: 1 Low degree of difficulty. Should be straightforward to implement and/or resolve. estimate: <2hrs Task which should take less than 2 hours. ❌ No AI Not allowed to use AI.

Comments

@Planeshifter
Copy link
Member

Planeshifter commented Feb 13, 2025 •
edited
Loading

See: stdlib-js/stdlib#2781 (comment)

Time estimate without AI: 2h.
Time estimate with AI: 1h 45min.
@kgryte kgryte added Bug Task to fix a bug. difficulty: 1 Low degree of difficulty. Should be straightforward to implement and/or resolve. estimate: <2hrs Task which should take less than 2 hours. labels Feb 14, 2025
@naterush naterush added 🤖 AI Allowed to use AI. ❌ No AI Not allowed to use AI. and removed 🤖 AI Allowed to use AI. labels Feb 17, 2025
@Planeshifter Planeshifter mentioned this issue Feb 22, 2025
Merged
1 task
@Planeshifter
Copy link
Member Author

PR-URL: stdlib-js/stdlib#5378

@Planeshifter
Copy link
Member Author

Planeshifter commented Feb 22, 2025 •
edited
Loading

Time to completion: 40min.

Time after initial PR: 0min.

@Planeshifter
Copy link
Member Author

Notes: Main time spent was reproducing the problem locally; fix is simply to install the missing dependency in the C benchmark workflow, which was done quickly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Planeshifter Planeshifter

Labels
Bug Task to fix a bug. difficulty: 1 Low degree of difficulty. Should be straightforward to implement and/or resolve. estimate: <2hrs Task which should take less than 2 hours. ❌ No AI Not allowed to use AI.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

build: install Cephes dependency in CI if used in benchmarks stdlib-js/stdlib
3 participants
@Planeshifter @kgryte @naterush