Skip to content

Commit 4be1cbe

Browse files
committed
feat!: Committing changes for draft review
1 parent 6e7e148 commit 4be1cbe

File tree

6 files changed

+17
-20
lines changed

6 files changed

+17
-20
lines changed

Diff for: lib/node_modules/@stdlib/math/base/special/minmaxabsf/benchmark/c/native/benchmark.c

+4-4
Original file line numberDiff line numberDiff line change
@@ -79,9 +79,9 @@ static double tic( void ) {
7979
*
8080
* @return random number
8181
*/
82-
static double rand_double( void ) {
82+
static float rand_float( void ) {
8383
int r = rand();
84-
return (double)r / ( (double)RAND_MAX + 1.0 );
84+
return (float)r / ( (float)RAND_MAX + 1.0f );
8585
}
8686

8787
/**
@@ -99,8 +99,8 @@ static double benchmark( void ) {
9999
int i;
100100

101101
for ( i = 0; i < 100; i++ ) {
102-
x[ i ] = ( 1000.0f * rand_double() ) - 500.0f;
103-
y[ i ] = ( 1000.0f * rand_double() ) - 500.0f;
102+
x[ i ] = ( 1000.0f * rand_float() ) - 500.0f;
103+
y[ i ] = ( 1000.0f * rand_float() ) - 500.0f;
104104
}
105105

106106
t = tic();

Diff for: lib/node_modules/@stdlib/math/base/special/minmaxabsf/examples/c/example.c

+1-1
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ int main( void ) {
3030
for ( i = 0; i < 100; i++ ) {
3131
x = ( ( (float)rand() / (float)RAND_MAX ) * 1000.0f ) - 500.0f;
3232
y = ( ( (float)rand() / (float)RAND_MAX ) * 1000.0f ) - 500.0f;
33-
v = stdlib_base_minmaxabsf( x, y, min, max );
33+
stdlib_base_minmaxabsf( x, y, &min, &max );
3434
printf( "x: %f, y: %f, minmaxabsf(x, y): %f %f\n", x, y, min, max );
3535
}
3636
}

Diff for: lib/node_modules/@stdlib/math/base/special/minmaxabsf/manifest.json

+3-9
Original file line numberDiff line numberDiff line change
@@ -40,9 +40,7 @@
4040
"@stdlib/napi/export",
4141
"@stdlib/napi/argv-float",
4242
"@stdlib/napi/argv-float32array",
43-
"@stdlib/math/base/assert/is-negative-zerof",
44-
"@stdlib/math/base/assert/is-nanf",
45-
"@stdlib/math/base/napi/binary",
43+
"@stdlib/math/base/napi/quaternary",
4644
"@stdlib/math/base/special/absf",
4745
"@stdlib/math/base/assert/is-nanf"
4846
]
@@ -62,9 +60,7 @@
6260
"@stdlib/napi/export",
6361
"@stdlib/napi/argv-float",
6462
"@stdlib/napi/argv-float32array",
65-
"@stdlib/math/base/assert/is-negative-zerof",
66-
"@stdlib/math/base/assert/is-nanf",
67-
"@stdlib/math/base/napi/binary",
63+
"@stdlib/math/base/napi/quaternary",
6864
"@stdlib/math/base/special/absf",
6965
"@stdlib/math/base/assert/is-nanf"
7066
]
@@ -84,9 +80,7 @@
8480
"@stdlib/napi/export",
8581
"@stdlib/napi/argv-float",
8682
"@stdlib/napi/argv-float32array",
87-
"@stdlib/math/base/assert/is-negative-zerof",
88-
"@stdlib/math/base/assert/is-nanf",
89-
"@stdlib/math/base/napi/binary",
83+
"@stdlib/math/base/napi/quaternary",
9084
"@stdlib/math/base/special/absf",
9185
"@stdlib/math/base/assert/is-nanf"
9286
]

Diff for: lib/node_modules/@stdlib/math/base/special/minmaxabsf/package.json

+2
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,9 @@
1919
"benchmark": "./benchmark",
2020
"doc": "./docs",
2121
"example": "./examples",
22+
"include": "./include",
2223
"lib": "./lib",
24+
"src": "./src",
2325
"test": "./test"
2426
},
2527
"types": "./docs/types",

Diff for: lib/node_modules/@stdlib/math/base/special/minmaxabsf/src/addon.c

+7-3
Original file line numberDiff line numberDiff line change
@@ -17,22 +17,26 @@
1717
*/
1818

1919
#include "stdlib/math/base/special/minmaxabsf.h"
20-
#include "stdlib/math/base/napi/binary.h"
2120
#include "stdlib/napi/argv.h"
2221
#include "stdlib/napi/argv_float.h"
2322
#include "stdlib/napi/argv_float32array.h"
2423
#include "stdlib/napi/export.h"
2524
#include <node_api.h>
2625

26+
/**
27+
* Receives JavaScript callback invocation data.
28+
*
29+
* @param env environment under which the function is invoked
30+
* @param info callback data
31+
* @return Node-API value
32+
*/
2733
static napi_value addon( napi_env env, napi_callback_info info ){
2834
STDLIB_NAPI_ARGV( env, info, argv, argc, 3 );
2935
STDLIB_NAPI_ARGV_FLOAT( env, x, argv, 0 );
3036
STDLIB_NAPI_ARGV_FLOAT( env, y, argv, 1 );
3137
STDLIB_NAPI_ARGV_FLOAT32ARRAY(env, out, len, argv, 2 );
32-
STDLIB_MATH_BASE_NAPI_MODULE_FF_F( stdlib_base_minmaxabsf );
3338
stdlib_base_minmaxabsf( x, y, &out[0], &out[1] );
3439
return NULL;
3540
}
3641

37-
// cppcheck-suppress shadowFunction
3842
STDLIB_NAPI_MODULE_EXPORT_FCN( addon )

Diff for: lib/node_modules/@stdlib/math/base/special/minmaxabsf/src/main.c

-3
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,6 @@
1919
#include "stdlib/math/base/special/minmaxabsf.h"
2020
#include "stdlib/math/base/assert/is_nanf.h"
2121
#include "stdlib/math/base/special/absf.h"
22-
// #include "stdlib/constants/float32/nan.h"
2322

2423
/**
2524
* Evaluates the single-precision min and max value.
@@ -34,13 +33,11 @@
3433
* float min;
3534
* float max;
3635
* float v = stdlib_base_minmaxabsf( 3.2, 4.1, &min, &max );
37-
* // returns [ 3.2f, 4.1f ]
3836
*
3937
* @example
4038
* float min;
4139
* float max;
4240
* float v = stdlib_base_minmaxabsf( 4.0, 0.0/0.0, &min, &max );
43-
* // returns [ NaN, NaN ]
4441
*/
4542
void stdlib_base_minmaxabsf( const float x, const float y, float* min, float* max ){
4643
if ( stdlib_base_is_nanf( x ) || stdlib_base_is_nanf( y ) ) {

0 commit comments

Comments
 (0)