-
-
Notifications
You must be signed in to change notification settings - Fork 805
[RFC]: skew-normal distribution #492
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
🎉 Welcome! 🎉 And thank you for opening your first issue! We will get back to you shortly. 🏃 💨 |
Hey, @quinn-dougherty! Thanks for filing this RFC. This would definitely be a nice distribution to have. Does entail, however, a more involved implementation. Namely, we'd need integration facilities (see SciPy) and Owen's T function (see https://www.jstatsoft.org/article/view/v005i05 (GPL)). @Planeshifter May have a better sense of how difficult this distribution may be to implement. |
For now, this is getting the job done for me:
(when a function suffices) Or this incredibly janky thing:
(when I need a proper distribution) |
Hey, @kgryte! I would like to work on that. I checked the SciPy source code you shared; they are using direct implementation of the formula here. On the contrary, in the paper, they are utilizing Owen's T function properties to bring down the |
@Prog-Jacob As a start, feel free to submit an initial PR which adds the |
@Prog-Jacob Or perhaps take an initial pass at adding Owen's T to |
@kgryte Boost is implementing the paper you referenced – Fast and Accurate Calculation of Owen's T Function. It looks hefty; should I initially focus on supporting Skewed Normal Distributions and work on Owen's T function later on? what do you think? |
@Prog-Jacob Sure. Sounds good. |
Description
This RFC proposes the skew-normal distribution
Related Issues
I didn't see any.
Questions
No.
Other
No.
Checklist
RFC:
.The text was updated successfully, but these errors were encountered: