Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RFC]: Add C implementations to base special math functions (tracking issue) #649

Open
kgryte opened this issue Dec 2, 2022 · 29 comments · Fixed by #3058, #3061, #3072 or #3076 · May be fixed by #3377
Open

[RFC]: Add C implementations to base special math functions (tracking issue) #649

kgryte opened this issue Dec 2, 2022 · 29 comments · Fixed by #3058, #3061, #3072 or #3076 · May be fixed by #3377
Labels
Accepted RFC feature request which has been accepted. difficulty: 3 Likely to be challenging but manageable. Enhancement Issue or pull request for enhancing existing functionality. Math Issue or pull request specific to math functionality. Native Addons Issue involves or relates to Node.js native add-ons. priority: High High priority concern or feature request. RFC Request for comments. Feature requests and proposed changes. Tracking Issue Tracking issue.

Comments

@kgryte
Copy link
Member

kgryte commented Dec 2, 2022 •
edited by anandkaranubc
Loading

Description

This RFC proposes adding C implementations to all base special math functions. The purpose of this issue is to serve as a tracking issue for adding C implementations.

Packages

  • abs
  • abs2
  • abs2f
  • absf
  • acos
  • acosf
  • acosd
  • acosdf
  • acosh
  • acoshf
  • acot
  • acotf
  • acotd
  • acotdf
  • acoth
  • acothf
  • acovercos
  • acovercosf
  • acoversin
  • acoversinf
  • acsc
  • acscf
  • acscd
  • acscdf
  • acsch
  • acschf
  • ahavercos
  • ahavercosf
  • ahaversin
  • ahaversinf
  • asec
  • asecf
  • asecd
  • asecdf
  • asech
  • asechf
  • asin
  • asinf
  • asind
  • asindf
  • asinf
  • asinh
  • asinhf
  • atan
  • atanf
  • atan2
  • atan2f
  • atand
  • atandf
  • atanh
  • atanhf
  • avercos
  • avercosf
  • aversin
  • aversinf
  • bernoulli
  • bernoullif
  • besselj0
  • besselj0f
  • besselj1
  • besselj1f
  • bessely0
  • bessely0f
  • bessely1
  • bessely1f
  • beta
  • betaf
  • betainc
  • betaincf
  • betaincinv
  • betaincinvf
  • betaln
  • betalnf
  • binet
  • binetf
  • binomcoef
  • binomcoeff
  • binomcoefln
  • binomcoeflnf
  • boxcox
  • boxcoxf
  • boxcox1p
  • boxcox1pf
  • boxcox1pinv
  • boxcox1pinvf
  • boxcoxinv
  • boxcoxinvf
  • cabs
  • cabs2
  • cabs2f
  • cabsf
  • cbrt
  • cbrtf
  • cceil
  • cceilf
  • cceiln
  • cceilnf
  • ccis
  • ccisf
  • ceil
  • ceil10
  • ceil10f
  • ceil2
  • ceil2f
  • ceilb
  • ceilbf
  • ceilf
  • ceiln
  • ceilnf
  • ceilsd
  • ceilsdf
  • cexp
  • cexpf
  • cflipsign
  • cflipsignf
  • cfloor
  • cfloorf
  • cfloorn
  • cfloornf
  • cidentity
  • cidentityf
  • cinv
  • cinvf
  • clamp
  • clampf
  • copysign
  • copysignf
  • cos
  • cosf
  • cosd
  • cosdf
  • cosh
  • coshf
  • cosm1
  • cosm1f
  • cospi
  • cospif
  • cot
  • cotf
  • cotd
  • cotdf
  • coth
  • cothf
  • covercos
  • covercosf
  • coversin
  • coversinf
  • cphase
  • cphasef
  • cpolar
  • cpolarf
  • cround
  • croundf
  • croundn
  • croundnf
  • csc
  • cscf
  • cscd
  • cscdf
  • csch
  • cschf
  • csignum
  • csignumf
  • deg2rad
  • deg2radf
  • digamma
  • digammaf
  • dirac-delta
  • dirac-deltaf
  • dirichlet-eta
  • dirichlet-etaf
  • ellipe
  • ellipef
  • ellipj
  • ellipjf
  • ellipk
  • ellipkf
  • erf
  • erff
  • erfc
  • erfcf
  • erfcinv
  • erfcinvf
  • erfcx
  • erfcxf
  • erfinv
  • erfinvf
  • exp
  • expf
  • exp10
  • exp10f
  • exp2
  • exp2f
  • expit
  • expitf
  • expm1
  • expm1f
  • expm1rel
  • expm1relf
  • factorial
  • factorialf
  • factorial2
  • factorial2f
  • factorialln
  • factoriallnf
  • falling-factorial
  • falling-factorialf
  • fast/*
  • fibonacci
  • fibonaccif
  • fibonacci-index
  • fibonacci-indexf
  • flipsign
  • flipsignf
  • floor
  • floor10
  • floor10f
  • floor2
  • floor2f
  • floorb
  • floorbf
  • floorf
  • floorn
  • floornf
  • floorsd
  • floorsdf
  • fmod
  • fmodf
  • fresnel
  • fresnelf
  • fresnelc
  • fresnelcf
  • fresnels
  • fresnelsf
  • frexp
  • frexpf
  • gamma
  • gammaf
  • gamma-delta-ratio
  • gamma-delta-ratiof
  • gamma-lanczos-sum
  • gamma-lanczos-sumf
  • gamma-lanczos-sum-expg-scaled
  • gamma-lanczos-sum-expg-scaledf
  • gamma1pm1
  • gamma1pm1f
  • gammainc
  • gammaincf
  • gammaincinv
  • gammaincinvf
  • gammaln
  • gammalnf
  • gammasgn
  • gammasgnf
  • gcd
  • gcdf
  • hacovercos
  • hacovercosf
  • hacoversin
  • hacoversinf
  • havercos
  • havercosf
  • haversin
  • haversinf
  • heaviside
  • heavisidef
  • hypot
  • hypotf
  • identity
  • identityf
  • inv
  • invf
  • kernel-betainc
  • kernel-betaincf
  • kernel-betaincinv
  • kernel-betaincinvf
  • kernel-cos
  • kernel-cosf
  • kernel-sin
  • kernel-sinf
  • kernel-tan
  • kernel-tanf
  • kronecker-delta
  • kronecker-deltaf
  • labs
  • lcm
  • lcmf
  • ldexp
  • ldexpf
  • ln
  • lnf
  • log
  • logf
  • log10
  • log10f
  • log1mexp
  • log1mexpf
  • log1p
  • log1pf
  • log1pexp
  • log1pexpf
  • log1pmx
  • log1pmxf
  • log2
  • log2f
  • logaddexp
  • logaddexpf
  • logit
  • logitf
  • lucas
  • lucasf
  • max
  • maxf
  • maxabs
  • maxabsf
  • maxabsn
  • maxn
  • min
  • minf
  • minabs
  • minabsf
  • minabsn
  • minmax
  • minmaxf
  • minmaxabs
  • minmaxabsf
  • minmaxabsn
  • minmaxn
  • minn
  • modf
  • modff
  • nanmax
  • nanmaxf
  • nanmin
  • nanminf
  • negafibonacci
  • negafibonaccif
  • negalucas
  • negalucasf
  • nonfibonacci
  • nonfibonaccif
  • pdiff
  • pdifff
  • polygamma
  • polygammaf
  • pow
  • powf
  • powm1
  • powm1f
  • rad2deg
  • rad2degf
  • ramp
  • rampf
  • rcbrt
  • rcbrtf
  • rempio2
  • rempio2f
  • riemann-zeta
  • riemann-zetaf
  • rising-factorial
  • rising-factorialf
  • round
  • roundf
  • round10
  • round10f
  • round2
  • round2f
  • roundb
  • roundbf
  • roundn
  • roundnf
  • roundsd
  • roundsdf
  • rsqrt
  • rsqrtf
  • sec
  • secd
  • secdf
  • secf
  • sici
  • sicif
  • signum
  • signumf
  • sin
  • sinf
  • sinc
  • sincf
  • sincos
  • sincosd
  • sincosdf
  • sincosf
  • sincospi
  • sincospif
  • sinh
  • sinhf
  • sinpi
  • sinpif
  • spence
  • spencef
  • sqrt
  • sqrt1pm1
  • sqrt1pm1f
  • sqrtf
  • sqrtpi
  • sqrtpif
  • tan
  • tanf
  • tand
  • tandf
  • tanh
  • tanhf
  • tribonacci
  • tribonaccif
  • trigamma
  • trigammaf
  • trunc
  • trunc10
  • trunc10f
  • trunc2
  • trunc2f
  • truncb
  • truncbf
  • truncf
  • truncn
  • truncnf
  • truncsd
  • truncsdf
  • vercos
  • vercosf
  • versin
  • versinf
  • wrap
  • wrapf
  • xlog1py
  • xlog1pyf
  • xlogy
  • xlogyf

Related Issues

None.

Questions

No.

Other

No.

Checklist

  • I have read and understood the Code of Conduct.
  • Searched for existing issues and pull requests.
  • The issue name begins with RFC:.
@kgryte kgryte added RFC Request for comments. Feature requests and proposed changes. Feature Issue or pull request for adding a new feature. Math Issue or pull request specific to math functionality. Native Addons Issue involves or relates to Node.js native add-ons. Enhancement Issue or pull request for enhancing existing functionality. and removed Feature Issue or pull request for adding a new feature. labels Dec 2, 2022
This was referenced Jan 30, 2024
Open
Open
@kgryte kgryte added difficulty: 3 Likely to be challenging but manageable. Accepted RFC feature request which has been accepted. priority: High High priority concern or feature request. labels Feb 25, 2024
This was referenced Mar 3, 2024
Closed
Closed
Closed
Closed
@Pratik772846
Copy link
Contributor

@kgryte I would like to work on this.

@Snehil-Shah Snehil-Shah mentioned this issue Mar 5, 2024
Closed
3 tasks
@Pratik772846 Pratik772846 mentioned this issue Mar 5, 2024
Closed
3 tasks
This was referenced Mar 5, 2024
Merged
Closed
Merged
@kgryte
Copy link
Member Author

kgryte commented Mar 6, 2024

@Pratik772846 I suggest picking one of the associated RFCs for updating a single package. This is a tracking issue.

@kgryte
Copy link
Member Author

kgryte commented Mar 6, 2024

@Pranavchiku As you've been managing a number of the RFCs and PRs, would you mind updating the OP to match the current state of implementations?

@kgryte kgryte added the Tracking Issue Tracking issue. label Mar 6, 2024
This was referenced Mar 7, 2024
Closed
Closed
Merged
@tudor-pagu tudor-pagu mentioned this issue Mar 7, 2024
Closed
3 tasks
@gunjjoshi gunjjoshi mentioned this issue Mar 7, 2024
Closed
3 tasks
@Rejoan-Sardar Rejoan-Sardar mentioned this issue Mar 7, 2024
Closed
3 tasks
This was referenced Mar 22, 2025
Open
Merged
Closed
kgryte added a commit that referenced this issue Mar 22, 2025
@Neerajpathak07 @kgryte
feat: add constants/float32/apery
8fa89e3 
PR-URL: #6304
Ref: #649
Co-authored-by: Athan Reines <[email protected]>
Reviewed-by: Athan Reines <[email protected]> 
Signed-off-by: Athan Reines <[email protected]>
@anandkaranubc anandkaranubc mentioned this issue Mar 23, 2025
Open
1 task
Girish-Garg pushed a commit to Girish-Garg/stdlib that referenced this issue Mar 23, 2025
@Neerajpathak07 @kgryte @Girish-Garg
feat: add constants/float32/apery
7b505d9 
PR-URL: stdlib-js#6304
Ref: stdlib-js#649
Co-authored-by: Athan Reines <[email protected]>
Reviewed-by: Athan Reines <[email protected]> 
Signed-off-by: Athan Reines <[email protected]>
@sahil20021008 sahil20021008 mentioned this issue Mar 23, 2025
Open
7 tasks
kgryte pushed a commit that referenced this issue Mar 24, 2025
@hrshya
feat: add constants/float32/num-significand-bits
56b84a4 
PR-URL: #6284
Ref: #649
Reviewed-by: Athan Reines <[email protected]>
Signed-off-by: Harsh <[email protected]>
@Neerajpathak07 Neerajpathak07 mentioned this issue Mar 24, 2025
Closed
1 task
Planeshifter pushed a commit that referenced this issue Mar 24, 2025
@Neerajpathak07
feat: add constants/float32/pi-squared
a77fb9e 
PR-URL: #6069
Closes: #6070
Ref: #649

Reviewed-by: Athan Reines <[email protected]> 
Reviewed-by: Philipp Burckhardt <[email protected]>
This was referenced Mar 24, 2025
Open
Closed
@anandkaranubc anandkaranubc mentioned this issue Mar 25, 2025
Merged
1 task
@hrshya hrshya mentioned this issue Mar 25, 2025
Closed
1 task
@Girish-Garg Girish-Garg mentioned this issue Mar 25, 2025
Closed
1 task
This was referenced Mar 25, 2025
Merged
Merged
sahil20021008 pushed a commit to sahil20021008/stdlib that referenced this issue Mar 26, 2025
@Neerajpathak07 @kgryte @sahil20021008
feat: add constants/float32/apery
26f3b59 
PR-URL: stdlib-js#6304
Ref: stdlib-js#649
Co-authored-by: Athan Reines <[email protected]>
Reviewed-by: Athan Reines <[email protected]> 
Signed-off-by: Athan Reines <[email protected]>
sahil20021008 pushed a commit to sahil20021008/stdlib that referenced this issue Mar 26, 2025
@hrshya @sahil20021008
feat: add constants/float32/num-significand-bits
19022b1 
PR-URL: stdlib-js#6284
Ref: stdlib-js#649
Reviewed-by: Athan Reines <[email protected]>
Signed-off-by: Harsh <[email protected]>
sahil20021008 pushed a commit to sahil20021008/stdlib that referenced this issue Mar 26, 2025
@Neerajpathak07 @sahil20021008
feat: add constants/float32/pi-squared
b533b4e 
PR-URL: stdlib-js#6069
Closes: stdlib-js#6070
Ref: stdlib-js#649

Reviewed-by: Athan Reines <[email protected]> 
Reviewed-by: Philipp Burckhardt <[email protected]>
kgryte added a commit that referenced this issue Apr 2, 2025
@hrshya @kgryte
feat: add constants/float32/fourth-root-eps
67d1bf8 
PR-URL: #6373
Ref: #649
Co-authored-by: Athan Reines <[email protected]>
Reviewed-by: Athan Reines <[email protected]> 
Signed-off-by: Athan Reines <[email protected]>
kgryte added a commit that referenced this issue Apr 2, 2025
@Neerajpathak07 @kgryte
feat: add constants/float32/eulergamma
baf9f87 
PR-URL: #6209
Ref: #649
Co-authored-by: Athan Reines <[email protected]>
Reviewed-by: Athan Reines <[email protected]> 
Signed-off-by: Athan Reines <[email protected]>
kgryte added a commit that referenced this issue Apr 2, 2025
@anandkaranubc @kgryte @stdlib-bot
feat: add math/base/special/csignumf
9b72f0c 
PR-URL: #6361
Ref: #649
Co-authored-by: Athan Reines <[email protected]>
Reviewed-by: Athan Reines <[email protected]> 
Signed-off-by: Athan Reines <[email protected]>
Co-authored-by: stdlib-bot <[email protected]>
kgryte added a commit that referenced this issue Apr 2, 2025
@hrshya @kgryte
feat: add constants/float32/min-ln
40ba86d 
PR-URL: #6261
Ref: #649
Co-authored-by: Athan Reines <[email protected]>
Reviewed-by: Athan Reines <[email protected]> 
Signed-off-by: Harsh <[email protected]>
Signed-off-by: Athan Reines <[email protected]>
kgryte added a commit that referenced this issue Apr 2, 2025
@hrshya @kgryte
feat: add constants/float32/max-ln
a83525e 
PR-URL: #6256
Ref: #649
Reviewed-by: Athan Reines <[email protected]>
Signed-off-by: Harsh <[email protected]>
Signed-off-by: Athan Reines <[email protected]>
Co-authored-by: Athan Reines <[email protected]>
kgryte pushed a commit that referenced this issue Apr 2, 2025
@anandkaranubc @stdlib-bot
feat: add math/base/special/fibonaccif
8297683 
PR-URL: #6257
Ref: #649
Reviewed-by: Athan Reines <[email protected]>
Co-authored-by: stdlib-bot <[email protected]>
kgryte added a commit that referenced this issue Apr 2, 2025
@anandkaranubc @kgryte @stdlib-bot
feat: add math/base/special/atan2d
f9cd43c 
PR-URL: #6273
Ref: #649
Co-authored-by: Athan Reines <[email protected]>
Reviewed-by: Athan Reines <[email protected]> 
Signed-off-by: Athan Reines <[email protected]>
Co-authored-by: stdlib-bot <[email protected]>
kgryte added a commit that referenced this issue Apr 2, 2025
@Neerajpathak07 @kgryte
feat: add constants/float32/catalan
8436708 
PR-URL: #6203
Ref: #649
Co-authored-by: Athan Reines <[email protected]>
Reviewed-by: Athan Reines <[email protected]> 
Signed-off-by: Athan Reines <[email protected]>
kgryte added a commit that referenced this issue Apr 2, 2025
@hrshya @kgryte @gunjjoshi
feat: add constants/float32/max-safe-lucas
0d59526 
PR-URL: #6374
Ref: #649
Co-authored-by: Athan Reines <[email protected]>
Reviewed-by: Athan Reines <[email protected]> 
Reviewed-by: Gunj Joshi <[email protected]>
Signed-off-by: Gunj Joshi <[email protected]>
Signed-off-by: Athan Reines <[email protected]>
Co-authored-by: Gunj Joshi <[email protected]>
@devesssi devesssi linked a pull request Apr 4, 2025 that will close this issue
Open
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Accepted RFC feature request which has been accepted. difficulty: 3 Likely to be challenging but manageable. Enhancement Issue or pull request for enhancing existing functionality. Math Issue or pull request specific to math functionality. Native Addons Issue involves or relates to Node.js native add-ons. priority: High High priority concern or feature request. RFC Request for comments. Feature requests and proposed changes. Tracking Issue Tracking issue.
Projects
None yet
Milestone
No milestone
9 participants
@Planeshifter @kgryte @gunjjoshi @Pranavchiku @sahil20021008 @Pratik772846 @Harsh-Mathur-1503 @anandkaranubc @Girish-Garg