Commit & push work fine on a manual Run workflow but not on a cron scheduled one #349
-
|
Hi I'm trying to create a github actions that runs on a cron scheduled time and use the git-auto-commit to handle the commit & push. Below is my yml file name: Data Collection & Sync
on:
workflow_dispatch:
schedule:
- cron: "11 17 * * *" # Run everyday at 17:11
jobs:
build:
runs-on: ubuntu-latest
permissions:
contents: write
steps:
- name: checkout repo content
uses: actions/checkout@v4 # checkout the repository content to github runner
with:
ref: ${{ github.head_ref }}
- name: setup python
uses: actions/setup-python@v5
with:
python-version: '3.12' # install the python version needed
- name: install python packages
run: |
python -m pip install --upgrade pip
pip install -r actions_requirements.txt
- name: execute py script # run main.py
env:
AUTH_KEY: ${{ secrets.AUTH_KEY }}
BASE_URL: ${{ secrets.BASE_URL }}
run: |
python wallet_accts.py
python acct_df.py
- name: Commit & Push
uses: stefanzweifel/git-auto-commit-action@v5
with:
commit_message: 'Synced data from API'When I manually run this workflow, it works perfectly. But when the cron scheduled action runs, I get the below error;
Please help |
Beta Was this translation helpful? Give feedback.
Replies: 3 comments 9 replies
-
|
Hi @Kamal-Moha, I assume these are the runs that cause the problems?
From what I can see in the logs and from your workflow file: everything looks alright. Are you 100% sure, that your Python scripts always changes files? name: Data Collection & Sync
on:
workflow_dispatch:
schedule:
- cron: '11 17 * * *' # Run everyday at 06:08
jobs:
build:
runs-on: ubuntu-latest
permissions:
contents: write
steps:
- name: checkout repo content
uses: actions/checkout@v4 # checkout the repository content to github runner
with:
ref: ${{ github.head_ref }}
- name: setup python
uses: actions/setup-python@v5
with:
python-version: '3.12' # install the python version needed
- name: install python packages
run: |
python -m pip install --upgrade pip
pip install -r actions_requirements.txt
- name: execute py script # run main.py
env:
AUTH_KEY: ${{ secrets.AUTH_KEY }}
BASE_URL: ${{ secrets.BASE_URL }}
run: |
python wallet_accts.py
python acct_df.py
+
+ - run: git status
+
- name: Commit & Push
uses: stefanzweifel/git-auto-commit-action@v5
with:
commit_message: 'Synced data from API'
|
Beta Was this translation helpful? Give feedback.
-
|
YES I'm 100% sure that those two python scripts actually create and save a dataframe in github
And when I run the workflow manually, both dataframes get created & saved in the proper directory. I have included a git status and will keep you posted on what I get. |
Beta Was this translation helpful? Give feedback.
-
|
Hi @stefanzweifel, I have included
I'm still seeing the "nothing to commit, working tree clean" and I honestly don't know why I'm getting this. How it works with manual run and not the scheduled? Need further help. |
Beta Was this translation helpful? Give feedback.
-
|
Hi @stefanzweifel, I confirm that the execution of this python scripts should generate & save/overwrite a csv file every time they're run. I'm not worried about the pyhon scripts. My question to you is this; Why is this working with manual run workflow and not for a scheduled cron one. Are there some settings that are turned off when doing a scheduled task? Let's start there |
Beta Was this translation helpful? Give feedback.
-
|
I hope my previous comment didn't come across as negative. As I don't know your project or know Pyhton, I just need to be sure where the problem is.
I don't know why this doesn't work for you. :( git-auto-commit isn't aware, how the workflow is being triggered. It doesn't know if it was through a schedule, manually or through a git-commit. The action is a "dumb" shell-script that just runs git-auto-commit-action/entrypoint.sh Lines 29 to 62 in 050015d Internally, git-auto-commit also runs git-status. The same command you've added as a separate step and that was executed here. As that command also returns "nothing to commit, working tree clean" before git-auto-commit is run, tells me, that something before has to be wrong. Could it be, that between manual trigger and scheduled trigger, no new data is available, that could be added to your files? |
Beta Was this translation helpful? Give feedback.
-
|
@stefanzweifel No your comment wasn't negative in any way, It was actually a good comment that made me dig deep into a few things & proofread my code.
Makes sense. From the above code, I see that I'm in the else part of this clause Let me also tell you that YES the csv file I'm creating might sometimes not have any detectable changes from the existing file. Does that mean in that case, git-auto-commit won't be able to push anything to github? Does git-auto-commit only push when changes are detected? And does that mean, just because the csv file isn't pushed, it doesn't mean scheduled github isn't working? This is insightful. Let me also briefly describe what I'm trying to do with this project. I want to create a scheduled cron job that runs every night at 11:55pm. The task is to have the python scripts request data from an API, manipulate that data & save it into a dataframe in the "Data" directory. That data is then used to make changes on a live dashboard. That's what I'm trying to do here. Thanks! |
Beta Was this translation helpful? Give feedback.
-
Yeah, that's correct.
Correct. If the file doesn't change, then git-auto-commit can't commit any changes and can't push them to GitHub.
Correct.
Correct. This workflow for example didn't cause an error. It's just that the CSV was not changed and therefore no changes were detected. Therefore nothing in the repo could be updated. |
Beta Was this translation helpful? Give feedback.
-
|
Hi @stefanzweifel, Could you please tell me how I can include the time & date in my commit message. For example, having something like "Data Collected & synced from API - {date} {time}". How can I have that in the yml file? |
Beta Was this translation helpful? Give feedback.
-
|
@Kamal-Moha You have to add a dedicated step to calculate the commit message. Here's an example, on how to add current date and time to the commit message. name: Data Collection & Sync
on:
workflow_dispatch:
schedule:
- cron: '05 16 * * *' # Run everyday at 06:08
jobs:
build:
runs-on: ubuntu-latest
permissions:
contents: write
steps:
- name: checkout repo content
uses: actions/checkout@v4 # checkout the repository content to github runner
with:
ref: ${{ github.head_ref }}
- name: setup python
uses: actions/setup-python@v5
with:
python-version: '3.12' # install the python version needed
- name: install python packages
run: |
python -m pip install --upgrade pip
pip install -r actions_requirements.txt
- name: execute py script # run main.py
env:
AUTH_KEY: ${{ secrets.AUTH_KEY }}
BASE_URL: ${{ secrets.BASE_URL }}
run: |
python wallet_accts.py
python acct_df.py
+ - name: Set commit message
+ id: commit_message_step
+ run: echo commit_message="Synced data from API" $(date '+%Y-%m-%d %H:%M:%S') >> $GITHUB_OUTPUT
- name: Commit & Push
uses: stefanzweifel/git-auto-commit-action@v5
with:
+ commit_message: ${{ steps.commit_message_step.outputs.commit_message }}
|
Beta Was this translation helpful? Give feedback.
-
|
Thank you @stefanzweifel, I have managed to include date & time in my commit message. Now I'm working on including Timezone but looks GHA doens't properly support timezones. I have found this git-auto-commit package to very helpful. And Btw, I would like to suggest to have the text "Working tree clean. Nothing to commit." be changed to something more clear & descriptive like "Nothing to commit because no changes have been detected", I think that would be helpful for future people who might face this issue |
Beta Was this translation helpful? Give feedback.
Yeah, that's correct.
Correct. If the file doesn't change, then git-auto-commit can't commit any changes and can't push them to GitHub.