Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove firstArrivingMeterValueIfMultiple #1209

Closed
3 tasks done
goekay opened this issue Aug 12, 2023 · 1 comment · Fixed by #1423
Closed
3 tasks done

Remove firstArrivingMeterValueIfMultiple #1209

goekay opened this issue Aug 12, 2023 · 1 comment · Fixed by #1423

Comments

@goekay
Copy link
Member

goekay commented Aug 12, 2023

Checklist

  • I checked other issues already and found no answer
  • I checked the documentation and found no answer
  • I am running the latest version and the feature i am requesting is not implemented there

Describe the problem you are trying to solve

I think this flag/feature is causing more harm than good. We should maybe question the added value of having it.

Describe alternative solutions or features you've considered

There are PRs that address the issues such as #1013 and #1164

Describe the solution you'd like

I am inclined to remove it altogether (instead of fixing it) and return the raw data from the table. Fixing it means adding more code that would make a complicated part even more complicated. Therefore, I ask the authors of these PRs and the wider community for their feedback.

Additional context

@fnkbsi
Copy link
Contributor

fnkbsi commented Aug 21, 2023

With the current implementation, the reduction of MeterValues is not important.
However, two potential new features could benefit from this:

  • Export of transaction details / MeterValues as CSV (works also without a "data reduction")
  • Visualization of the transaction / charging process using SVG graphics

What I definitely don't need is the data reduction with the last arriving MeterValue (firstArrivingMeterValueIfMultiple == false).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants