Skip to content

Commit 102f5e8

Browse files
authored
Merge pull request kubernetes-sigs#16 from DirectXMan12/deps/release-1.10-rc
Update deps to k8s 1.10-rc.1
2 parents c0edef5 + b1a77f1 commit 102f5e8

File tree

8 files changed

+122
-71
lines changed

8 files changed

+122
-71
lines changed

glide.lock

+97-60
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

glide.yaml

+18
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,20 @@
11
package: github.com/kubernetes-incubator/custom-metrics-apiserver
22
import:
33
- package: github.com/emicklei/go-restful
4+
version: 2.2.1 # close to kubernetes Godeps.json
5+
46
- package: github.com/emicklei/go-restful-swagger12
7+
version: 1.0.1 # from kubernetes Godeps.json
8+
59
- package: github.com/go-openapi/spec
10+
version: 1de3e0542de65ad8d75452a595886fdd0befb363 # from kubernetes Godeps.json
11+
612
- package: github.com/golang/glog
13+
version: 44145f04b68cf362d9c4df2182967c2275eaefed # from kubernetes Godep.json
14+
715
- package: github.com/spf13/cobra
16+
version: c439c4fa093711d42e1b01acb1235b52004753c1 # from kubernetes Godeps.json
17+
818
- package: k8s.io/apimachinery
919
subpackages:
1020
- pkg/api/errors
@@ -23,6 +33,8 @@ import:
2333
- pkg/util/errors
2434
- pkg/util/wait
2535
- pkg/version
36+
tag: kubernetes-1.10.0-rc.1
37+
2638
- package: k8s.io/apiserver
2739
subpackages:
2840
- pkg/endpoints
@@ -35,6 +47,8 @@ import:
3547
- pkg/server
3648
- pkg/server/options
3749
- pkg/util/logs
50+
tag: kubernetes-1.10.0-rc.1
51+
3852
- package: k8s.io/client-go
3953
subpackages:
4054
- discovery
@@ -46,12 +60,16 @@ import:
4660
- rest
4761
- testing
4862
- tools/clientcmd
63+
tag: kubernetes-1.10.0-rc.1
64+
4965
- package: k8s.io/metrics
5066
subpackages:
5167
- pkg/apis/custom_metrics
5268
- pkg/apis/custom_metrics/install
5369
- pkg/apis/external_metrics
5470
- pkg/apis/external_metrics/install
71+
tag: kubernetes-1.10.0-rc.1
72+
5573
testImport:
5674
- package: github.com/stretchr/testify
5775
version: ^1.1.4

pkg/apiserver/cmapis.go

-2
Original file line numberDiff line numberDiff line change
@@ -75,13 +75,11 @@ func (s *CustomMetricsAdapterServer) cmAPI(groupMeta *apimachinery.GroupMeta, gr
7575
Creater: Scheme,
7676
Convertor: Scheme,
7777
UnsafeConvertor: runtime.UnsafeObjectConvertor(Scheme),
78-
Copier: Scheme,
7978
Typer: Scheme,
8079
Linker: groupMeta.SelfLinker,
8180
Mapper: groupMeta.RESTMapper,
8281

8382
Context: s.GenericAPIServer.RequestContextMapper(),
84-
MinRequestTimeout: s.GenericAPIServer.MinRequestTimeout(),
8583
OptionsExternalVersion: &schema.GroupVersion{Version: "v1"},
8684
},
8785

pkg/apiserver/emapis.go

-2
Original file line numberDiff line numberDiff line change
@@ -76,13 +76,11 @@ func (s *CustomMetricsAdapterServer) emAPI(groupMeta *apimachinery.GroupMeta, gr
7676
Creater: Scheme,
7777
Convertor: Scheme,
7878
UnsafeConvertor: runtime.UnsafeObjectConvertor(Scheme),
79-
Copier: Scheme,
8079
Typer: Scheme,
8180
Linker: groupMeta.SelfLinker,
8281
Mapper: groupMeta.RESTMapper,
8382

8483
Context: s.GenericAPIServer.RequestContextMapper(),
85-
MinRequestTimeout: s.GenericAPIServer.MinRequestTimeout(),
8684
OptionsExternalVersion: &schema.GroupVersion{Version: "v1"},
8785
},
8886
ResourceLister: provider.NewExternalMetricResourceLister(s.externalMetricsProvider),

pkg/apiserver/installer/apiserver_test.go

-2
Original file line numberDiff line numberDiff line change
@@ -130,7 +130,6 @@ func handleCustomMetrics(prov provider.CustomMetricsProvider) http.Handler {
130130
Creater: Scheme,
131131
Convertor: Scheme,
132132
UnsafeConvertor: runtime.UnsafeObjectConvertor(Scheme),
133-
Copier: Scheme,
134133
Typer: Scheme,
135134
Linker: customMetricsGroupMeta.SelfLinker,
136135
Mapper: customMetricsGroupMeta.RESTMapper,
@@ -170,7 +169,6 @@ func handleExternalMetrics(prov provider.ExternalMetricsProvider) http.Handler {
170169
Creater: Scheme,
171170
Convertor: Scheme,
172171
UnsafeConvertor: runtime.UnsafeObjectConvertor(Scheme),
173-
Copier: Scheme,
174172
Typer: Scheme,
175173
Linker: externalMetricsGroupMeta.SelfLinker,
176174
Mapper: externalMetricsGroupMeta.RESTMapper,

pkg/apiserver/installer/cmhandlers.go

+2-1
Original file line numberDiff line numberDiff line change
@@ -118,10 +118,11 @@ func (ch *CMHandlers) registerResourceHandlers(a *MetricsAPIInstaller, ws *restf
118118
ParameterCodec: a.group.ParameterCodec,
119119
Creater: a.group.Creater,
120120
Convertor: a.group.Convertor,
121-
Copier: a.group.Copier,
122121
Typer: a.group.Typer,
123122
UnsafeConvertor: a.group.UnsafeConvertor,
124123

124+
// TODO: support TableConvertor?
125+
125126
// TODO: This seems wrong for cross-group subresources. It makes an assumption that a subresource and its parent are in the same group version. Revisit this.
126127
Resource: a.group.GroupVersion.WithResource("*"),
127128
Subresource: "*",

pkg/apiserver/installer/emhandlers.go

+2-1
Original file line numberDiff line numberDiff line change
@@ -98,10 +98,11 @@ func (ch *EMHandlers) registerResourceHandlers(a *MetricsAPIInstaller, ws *restf
9898
ParameterCodec: a.group.ParameterCodec,
9999
Creater: a.group.Creater,
100100
Convertor: a.group.Convertor,
101-
Copier: a.group.Copier,
102101
Typer: a.group.Typer,
103102
UnsafeConvertor: a.group.UnsafeConvertor,
104103

104+
// TODO: support TableConvertor?
105+
105106
// TODO: This seems wrong for cross-group subresources. It makes an assumption that a subresource and its parent are in the same group version. Revisit this.
106107
Resource: a.group.GroupVersion.WithResource("*"),
107108
Subresource: "*",

pkg/cmd/server/start.go

+3-3
Original file line numberDiff line numberDiff line change
@@ -66,14 +66,14 @@ func (o CustomMetricsAdapterServerOptions) Config() (*apiserver.Config, error) {
6666
}
6767

6868
serverConfig := genericapiserver.NewConfig(apiserver.Codecs)
69-
if err := o.SecureServing.ApplyTo(serverConfig); err != nil {
69+
if err := o.SecureServing.ApplyTo(&serverConfig.SecureServing); err != nil {
7070
return nil, err
7171
}
7272

73-
if err := o.Authentication.ApplyTo(serverConfig); err != nil {
73+
if err := o.Authentication.ApplyTo(&serverConfig.Authentication, serverConfig.SecureServing, nil); err != nil {
7474
return nil, err
7575
}
76-
if err := o.Authorization.ApplyTo(serverConfig); err != nil {
76+
if err := o.Authorization.ApplyTo(&serverConfig.Authorization); err != nil {
7777
return nil, err
7878
}
7979

0 commit comments

Comments
 (0)