Skip to content

Timer example is incorrect #163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
systec-ms opened this issue Dec 10, 2021 · 6 comments
Closed

Timer example is incorrect #163

systec-ms opened this issue Dec 10, 2021 · 6 comments
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@systec-ms
Copy link
Contributor

If the interrupt is not cleared, it will immediately retriggered after the ISR has finished.

    timer.clear_interrupt(Event::TimeOut);
@hannobraun
Copy link
Contributor

Good catch, thank you!

@systec-ms
Copy link
Contributor Author

@hannobraun could you add good first issue as a label, I can't. Thanks.

@hannobraun hannobraun added bug Something isn't working good first issue Good for newcomers labels Dec 10, 2021
@hannobraun
Copy link
Contributor

Good call!

@systec-ms systec-ms changed the title Timer example is incorrect (good first issue) Timer example is incorrect Dec 10, 2021
@ghost
Copy link

ghost commented Jan 16, 2022

@systec-ms is there a repro case, or was this found by inspection?

@systec-ms
Copy link
Contributor Author

@systec-ms is there a repro case, or was this found by inspection?

Inspection.

@maximeborges maximeborges mentioned this issue Jan 28, 2022
Merged
@eldruin
Copy link
Member

eldruin commented Feb 20, 2022

Fixed in #169. Closing.

@eldruin eldruin closed this as completed Feb 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@eldruin @hannobraun @systec-ms