You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Is your feature request related to a problem? Please describe.
Apologies if the title is weird, not sure how else to describe in a one-liner. Basically, storybook allows parameterization at the story, component and global level (at least, I think).
I'd love to be able to have any permutation of a subset or whole of the following in their own design sub- abs:
Define a global design embed for my org's Style Guide
2. ie via preview.js
Define a component level design embed for a particular, well, component
4. ie via component-level parameters
Finally, define a story-level embed ... as above etc
Realistically, I'm only ever gonna use (1.) and (3.) above, but others' usage patterns may vary.
Describe the solution you'd like
Currently we can always pass in an array to define multiple links - but it isn't clear from the source code or demo storybook instance that we can define, eg:
Extending the parameter might enable users to define global items, but I'm not willing to add more unions to the parameter in the current version, for the sake of maintainability and from an API design perspective.
// CurrenttypeParameter=Config|Config[]// This solves?typeParameter=|Config|Config[]|{[key: string]: Config}// Breaking, but much betterinterfaceParameter{[key: string]: Config}
@pocka thanks for looking into this. That's good reasoning.
What kind of help would you want? Or specifically, I'd like to help, but I'm not sure how you want that to fit into whatever release schedule you've got
I've put the help wanted label for a "feedback requested" purpose just because I'm lazy...
Currently, there is no specific timeline for the next major (v7), but I hope I can ship it before this November. I'd like to add this change to the v8 so that users can upgrade to storybook-addon-designs@v7 (add support for Storybook v7) without touching the addon-specific things. Sorry for the inconvenience.
Tasks for this change would be something like this:
Use zod or something similar for config parsing. Checking Config | { [key: string]: Config } by hand definitely will cause a lot of bug...
Is your feature request related to a problem? Please describe.
Apologies if the title is weird, not sure how else to describe in a one-liner. Basically, storybook allows parameterization at the story, component and global level (at least, I think).
I'd love to be able to have any permutation of a subset or whole of the following in their own
design
sub- abs:2. ie via
preview.js
4. ie via component-level
parameters
Realistically, I'm only ever gonna use (1.) and (3.) above, but others' usage patterns may vary.
Describe the solution you'd like
Currently we can always pass in an array to define multiple links - but it isn't clear from the source code or demo storybook instance that we can define, eg:
preview.js
:some-story.jsx
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Design types
figma
figspec
link
image
iframe
Additional context
Add any other context or screenshots about the feature request here.
Thanks for your wonderful work on this so far <3
The text was updated successfully, but these errors were encountered: