Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate PrivVal from socket to grpc #39

Closed
jackzampolin opened this issue Jan 12, 2022 · 2 comments
Closed

Migrate PrivVal from socket to grpc #39

jackzampolin opened this issue Jan 12, 2022 · 2 comments
Labels
Type: Enhancement Type: Maintenance updates w/out changing functionality

Comments

@jackzampolin
Copy link
Member

tendermint/tendermint#5883

We have about a year for this but good to get it up in the issues

@boojamya boojamya added Type: Enhancement Type: Maintenance updates w/out changing functionality labels Feb 9, 2022
@boojamya boojamya added this to the v2.1.0 milestone Feb 9, 2022
@boojamya boojamya modified the milestones: v2.1.0, v3.0.0 Apr 19, 2022
@agouin
Copy link
Member

agouin commented May 3, 2022

This will be a change in the way tendermint connects to the sentry nodes (introduced in v0.35.0)

One idea is to use horcrux v3.x for the new grpc connection, and remove the socket connection from v3. Then users on chains using tendermint <v0.35.0 could use v2.x, and we could maintain it on a separate branch (e.g. v2.x for the 2.x trunk and main for the 3.x trunk).

Another idea is to have a config parameter in v3.x to allow using either the socket or the grpc connection. This would mean more permutations in the code but we would only have to maintain one branch, and users could use v3.x for any version of tendermint.

@akc2267
Copy link
Contributor

akc2267 commented Jan 29, 2024

grpc is now in horcrux

@akc2267 akc2267 closed this as completed Jan 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement Type: Maintenance updates w/out changing functionality
Projects
None yet
Development

No branches or pull requests

4 participants