Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows users who add tags with the
pmpromc_user_data
filter to also have these tags properly synced by MailChimp. Changes nothing if the users are not adding tags with a filter.Right now it is possible for users of this add-on to ask MailChimp to include tags by creating a filter like this:
The problem is that MailChimp will, by default, only add tags to a list member. If a user of this add-on is going to the trouble to add tags at all, then the more likely case is that they intend for MailChimp to sync these tags for the member. In fact this is analogous to the fact that the add-on already assumes we want to update the existing user on line 172. All we are suggesting is that this updating should extend to tags as well, if tags are supplied.
An acceptable alternative would be to provide a filter for the
$data
being created on line 170, but that seems to us to be be overkill in this instance. It is hard to imagine use cases where someone goes to the trouble of specifying tags and does not want them synced.Note that this, in part, would help satisfy this enhancement request for users who are comfortable using filters.