Merge pull request #820 from TomWright/master

dolmen · web-flow · commit 632a26080fa3 · 2024-03-06T03:05:06.000+01:00
Do not get argument again unnecessarily in Arguments.Error()
diff --git a/mock/mock.go b/mock/mock.go
@@ -1092,7 +1092,7 @@ func (args Arguments) Error(index int) error {
 		return nil
 	}
 	if s, ok = obj.(error); !ok {
-		panic(fmt.Sprintf("assert: arguments: Error(%d) failed because object wasn't correct type: %v", index, args.Get(index)))
+		panic(fmt.Sprintf("assert: arguments: Error(%d) failed because object wasn't correct type: %v", index, obj))
 	}
 	return s
 }

Original file line number	Diff line number	Diff line change
`@@ -1092,7 +1092,7 @@ func (args Arguments) Error(index int) error {`
`1092`	`1092`	`return nil`
`1093`	`1093`	`}`
`1094`	`1094`	`if s, ok = obj.(error); !ok {`
`1095`		`- panic(fmt.Sprintf("assert: arguments: Error(%d) failed because object wasn't correct type: %v", index, args.Get(index)))`
	`1095`	`+ panic(fmt.Sprintf("assert: arguments: Error(%d) failed because object wasn't correct type: %v", index, obj))`
`1096`	`1096`	`}`
`1097`	`1097`	`return s`
`1098`	`1098`	`}`