Address comments

Signed-off-by: OwenCorrigan76 <[email protected]>

Author: OwenCorrigan76

operator/src/main/java/io/strimzi/kafka/access/KafkaAccessReconciler.java

@@ -37,7 +37,7 @@
 /**
  * The custom reconciler of Strimzi Access Operator
  */
-@SuppressWarnings({"ClassFanOutComplexity"})
+@SuppressWarnings("ClassFanOutComplexity")
 @ControllerConfiguration
 public class KafkaAccessReconciler implements Reconciler<KafkaAccess> {
 
@@ -141,7 +141,8 @@ private void createOrUpdateSecret(final Map<String, String> data, final KafkaAcc
     }
 
     /**
-     * Prepares the event sources required for triggering the reconciliation. This tells the JOSDK framework which resources the operator needs to watch.
+     * Prepares the event sources required for triggering the reconciliation.
+     * It configures the JOSDK framework with resources the operator needs to watch.
      *
      * @param context       The EventSourceContext for KafkaAccess resource
      *

operator/src/test/java/io/strimzi/kafka/access/KafkaAccessReconcilerTest.java

@@ -72,7 +72,12 @@ public class KafkaAccessReconcilerTest {
     @BeforeEach
     void beforeEach() {
         operator = new Operator(overrider -> overrider.withKubernetesClient(client)
-                .withUseSSAToPatchPrimaryResource(false)); // Motivation: mock Kubernetes client doesn't fully support some SSA features.
+                /**
+                 * Disables the use of Server-Side Apply for patching the primary resource.
+                 * Motivation: Mock Kubernetes client doesn't fully support SSA features.
+                 * See: <a href="https://github.com/fabric8io/kubernetes-client/issues/5337">fabric8io/kubernetes-client Issue #5337</a>
+                 **/
+                .withUseSSAToPatchPrimaryResource(false));
         operator.register(new KafkaAccessReconciler(operator.getKubernetesClient()));
         operator.start();
     }
@@ -323,6 +328,7 @@ void testReconcileWithExistingSecret() {
         customAnnotation.put("my-custom", "annotation");
         secret.setMetadata(new ObjectMetaBuilder(secret.getMetadata()).addToAnnotations(customAnnotation).build());
         client.secrets().inNamespace(NAMESPACE).resource(secret).create();
+
         client.resources(KafkaAccess.class).resource(kafkaAccess).create();
         client.resources(KafkaAccess.class).inNamespace(NAMESPACE).withName(NAME).waitUntilCondition(updatedKafkaAccess -> {
             final Optional<String> bindingName = Optional.ofNullable(updatedKafkaAccess)

pom.xml

@@ -71,7 +71,6 @@
         <!-- Runtime dependencies -->
         <javaoperatorsdk.version>5.1.2</javaoperatorsdk.version>
         <fabric8.version>7.2.0</fabric8.version>
-        <fabric8-client.version>7.4.0</fabric8-client.version>
         <sundrio.version>0.200.0</sundrio.version>
         <strimzi.version>0.48.0</strimzi.version>
         <kafka.clients.version>4.1.0</kafka.clients.version>