-
Notifications
You must be signed in to change notification settings - Fork 26
[ST] Add MustGather and publish logs from tests in AZP #109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
im-konge
wants to merge
9
commits into
strimzi:main
Choose a base branch
from
im-konge:store-logs-correctly
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+247
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lukas Kral <[email protected]>
Signed-off-by: Lukas Kral <[email protected]>
see-quick
reviewed
Nov 11, 2025
systemtest/src/test/java/io/strimzi/kafka/access/KafkaAccessOperatorST.java
Outdated
Show resolved
Hide resolved
283895b to
eb6bbe5
Compare
Signed-off-by: Lukas Kral <[email protected]>
eb6bbe5 to
9988894
Compare
Signed-off-by: Lukas Kral <[email protected]>
Signed-off-by: Lukas Kral <[email protected]>
Signed-off-by: Lukas Kral <[email protected]>
d47be47 to
f5c21bb
Compare
Signed-off-by: Lukas Kral <[email protected]>
Signed-off-by: Lukas Kral <[email protected]>
kornys
approved these changes
Nov 12, 2025
Member
kornys
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💯
see-quick
approved these changes
Nov 12, 2025
Member
see-quick
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, Thanks @im-konge 👍 ... just a few minor nits to consider, nothing critical.
systemtest/src/main/java/io/strimzi/kafka/access/log/MustGatherImpl.java
Outdated
Show resolved
Hide resolved
systemtest/src/main/java/io/strimzi/kafka/access/log/MustGatherImpl.java
Show resolved
Hide resolved
Signed-off-by: Lukas Kral <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds LogCollector from Test-Frame to the STs + it adds step for publishing the logs from the failed STs.
The structure of folders used by LogCollector (and KubeResourceManager) looks like this:
The correct behavior on AZP was tested and can be checked here: https://dev.azure.com/cncf/strimzi/_build/results?buildId=187634&view=results (under the published artifacts).