Make httpClient() a public, static method (#1810)

* Make `httpClient()` a public, static method

* Make `streamingHttpClient()` a public, static method

Author: dejagersh

lib/ApiRequestor.php

@@ -436,8 +436,8 @@ private function _prepareRequest($method, $url, $params, $headers, $apiMode)
         // X-Stripe-Client-User-Agent header via the optional getUserAgentInfo()
         // method
         $clientUAInfo = null;
-        if (\method_exists($this->httpClient(), 'getUserAgentInfo')) {
-            $clientUAInfo = $this->httpClient()->getUserAgentInfo();
+        if (\method_exists(self::httpClient(), 'getUserAgentInfo')) {
+            $clientUAInfo = self::httpClient()->getUserAgentInfo();
         }
 
         if ($params && \is_array($params)) {
@@ -518,7 +518,7 @@ private function _requestRaw($method, $url, $params, $headers, $apiMode, $usage)
 
         $requestStartMs = Util\Util::currentTimeMillis();
 
-        list($rbody, $rcode, $rheaders) = $this->httpClient()->request(
+        list($rbody, $rcode, $rheaders) = self::httpClient()->request(
             $method,
             $absUrl,
             $rawHeaders,
@@ -562,7 +562,7 @@ private function _requestRawStreaming($method, $url, $params, $headers, $apiMode
 
         $requestStartMs = Util\Util::currentTimeMillis();
 
-        list($rbody, $rcode, $rheaders) = $this->streamingHttpClient()->requestStream(
+        list($rbody, $rcode, $rheaders) = self::streamingHttpClient()->requestStream(
             $method,
             $absUrl,
             $rawHeaders,
@@ -673,7 +673,7 @@ public static function resetTelemetry()
     /**
      * @return HttpClient\ClientInterface
      */
-    private function httpClient()
+    public static function httpClient()
     {
         if (!self::$_httpClient) {
             self::$_httpClient = HttpClient\CurlClient::instance();
@@ -685,7 +685,7 @@ private function httpClient()
     /**
      * @return HttpClient\StreamingClientInterface
      */
-    private function streamingHttpClient()
+    public static function streamingHttpClient()
     {
         if (!self::$_streamingHttpClient) {
             self::$_streamingHttpClient = HttpClient\CurlClient::instance();