change error thrown for null byte issues (#1813)

stripe · Feb 5, 2025 · 931c31f · 931c31f
1 parent 067658d
commit 931c31f
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/lib/ApiRequestor.php b/lib/ApiRequestor.php
@@ -519,7 +519,7 @@ private function _requestRaw($method, $url, $params, $headers, $apiMode, $usage)
         // for some reason, PHP users will sometimes include null bytes in their paths, which leads to cryptic server 400s.
         // we'll be louder about this to help catch issues earlier.
         if (false !== \strpos($absUrl, "\0") || false !== \strpos($absUrl, '%00')) {
-            throw new Exception\BadMethodCallException("URLs may not contain null bytes ('\\0'); double check any IDs you're including with the request.");
+            throw new Exception\InvalidRequestException("URLs may not contain null bytes ('\\0'); double check any IDs you're including with the request.");
         }
 
         $requestStartMs = Util\Util::currentTimeMillis();

diff --git a/tests/Stripe/ApiRequestorTest.php b/tests/Stripe/ApiRequestorTest.php
@@ -729,15 +729,15 @@ public function testIsDisabled()
 
     public function testRaisesForNullBytesInResourceMethod()
     {
-        $this->expectException(\Stripe\Exception\BadMethodCallException::class);
+        $this->expectException(\Stripe\Exception\InvalidRequestException::class);
         $this->compatExpectExceptionMessageMatches('#null byte#');
 
         Charge::retrieve("abc_123\0");
     }
 
     public function testRaisesForNullBytesInRawRequest()
     {
-        $this->expectException(\Stripe\Exception\BadMethodCallException::class);
+        $this->expectException(\Stripe\Exception\InvalidRequestException::class);
         $this->compatExpectExceptionMessageMatches('#null byte#');
 
         $client = new BaseStripeClient([