Skip to content
This repository was archived by the owner on Mar 7, 2019. It is now read-only.

Current typescript ruleset requires eslint-plugin-typescript as a "peer" dependency #47

Closed
behalka opened this issue Jan 30, 2019 · 2 comments
Labels

Comments

@behalka
Copy link

behalka commented Jan 30, 2019

Steps to reproduce:

  • I installed ruleset with this .eslintrc.js configuration:
'use strict'

module.exports = {
  parser: '@typescript-eslint/parser',
  plugins: ['@typescript-eslint'],

  extends: [
    '@strv/javascript/environments/nodejs/v10',
    '@strv/javascript/environments/nodejs/optional',
    '@strv/javascript/environments/typescript/recommended',
    '@strv/javascript/coding-styles/recommended',
  ],
}
  • I got this error:
Failed to load plugin typescript: Cannot find module 'eslint-plugin-typescript' ...
  • If I comment out the ruleset with typescript, eslint works :)

The @typescript-eslint library went under some changes and the eslint-plugin-typescript was required before so I suppose it's only needed to bump some dependencies in our library :) Hope this helps.

Current workaround now is to install eslint-plugin-typescript as a dev dependency into my project and everything works :)

@robertrossmann
Copy link
Member

This might be fixed in 9.2.0, via #45 which also added the missing rule plugin (sorry for that, my bad 😇), could you try once more with the new version and let me know? Thanks!

@behalka
Copy link
Author

behalka commented Feb 6, 2019

@robertrossmann I can confirm it's fixed :) 🎉

@behalka behalka closed this as completed Feb 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants