Revise test function to improve readability

Author: NimaSarajpoor

tests/test_cache.py

@@ -10,51 +10,48 @@
 
 def test_cache_save():
     def get_cache_fnames_ref():
-        cache._clear()
+        cache.clear()
         cache._enable()
         stump(np.random.rand(10), 3)
-        cache_data_fnames = [
-            fname for fname in cache._get_cache() if fname.endswith(".nbc")
-        ]
-        cache_index_fnames = [
-            fname for fname in cache._get_cache() if fname.endswith(".nbi")
-        ]
-        cache._clear()
-        return cache_data_fnames, cache_index_fnames
+        cache_files = cache._get_cache()
+        cache.clear()
+        return cache_files
 
     def get_cache_fnames_comp():
-        cache._clear()
-        cache._save()
+        cache.clear()
+        cache.save()
         stump(np.random.rand(10), 3)
-        cache_data_fnames = [
-            fname for fname in cache._get_cache() if fname.endswith(".nbc")
-        ]
-        cache_index_fnames = [
-            fname for fname in cache._get_cache() if fname.endswith(".nbi")
-        ]
-        cache._clear()
-        return cache_data_fnames, cache_index_fnames
+        cache_files = cache._get_cache()
+        cache.clear()
+        return cache_files
 
-    ref_data, ref_index = get_cache_fnames_ref()
-    comp_data, comp_index = get_cache_fnames_comp()
+    ref_cache_files = get_cache_fnames_ref()
+    comp_cache_files = get_cache_fnames_comp()
 
-    assert sorted(ref_data) == sorted(comp_data)
-    assert set(ref_index).issubset(comp_index)
+    # check nbc files
+    ref_nbc = [fname for fname in ref_cache_files if fname.endswith(".nbc")]
+    comp_nbc = [fname for fname in comp_cache_files if fname.endswith(".nbc")]
+    assert sorted(ref_nbc) == sorted(comp_nbc)
+
+    # check nbi files
+    ref_nbi = [fname for fname in ref_cache_files if fname.endswith(".nbi")]
+    comp_nbi = [fname for fname in comp_cache_files if fname.endswith(".nbi")]
+    assert set(ref_nbi).issubset(comp_nbi)
 
 
 def test_cache_save_after_clear():
     T = np.random.rand(10)
     m = 3
     stump(T, m)
 
-    cache._save()
+    cache.save()
     ref_cache = cache._get_cache()
 
-    cache._clear()
+    cache.clear()
     # testing cache._clear()
     assert len(cache._get_cache()) == 0
 
-    cache._save()
+    cache.save()
     comp_cache = cache._get_cache()
 
     # testing cache._save() after cache._clear()