[JavaScript] Fix scope of generator operator (#4509)

This commit scopes `*` after `yield` and `function`
`storage.modifier.generator` as current scope is not part of scope naming
guideline.

The asterisk turns a function into a generator when following the `function`
keyword.

The `yield*` expression delegates value generation to another generator like
`yield from` in Python.

Author: deathaxe

JavaScript/JavaScript.sublime-syntax

@@ -1662,7 +1662,7 @@ contexts:
         - match: $
           pop: 1
         - match: \*
-          scope: keyword.generator.asterisk.js
+          scope: storage.modifier.generator.js
           set: expression-begin
         - match: (?=\S)
           set: expression-begin
@@ -1867,7 +1867,7 @@ contexts:
 
   function-declaration-expect-generator-star:
     - match: \*
-      scope: keyword.declaration.generator.js
+      scope: storage.modifier.generator.js
       pop: 1
     - include: else-pop
 

JavaScript/tests/syntax_test_js.js

@@ -160,7 +160,7 @@ someFunction({
 //  ^^^ entity.name.function variable.other.readwrite
 //        ^^^^^^^^^^^ meta.function - meta.function meta.function
 //        ^^^^^^^^ keyword.declaration.function
-//                ^ keyword.declaration.generator
+//                ^ storage.modifier.generator.js
     {
 
     }

JavaScript/tests/syntax_test_js_control.js

@@ -385,9 +385,13 @@ while (true)
     x = yield;
 //      ^^^^^ keyword.control.flow.yield
 
+    x = yield* 42;
+//      ^^^^^ keyword.control.flow.yield
+//           ^ storage.modifier.generator.js
+
     x = yield * 42;
 //      ^^^^^ keyword.control.flow.yield
-//            ^ keyword.generator.asterisk
+//            ^ storage.modifier.generator.js
 
     x = yield
     function f() {}